[v1] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie

[PATCH] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie

Posted by Seonbin Yoon 1 month, 2 weeks ago

Rename variable pHT_info_ie to p_ht_info_ie to comply with
kernel coding style (snake_case).

Fixes the following checkpatch warning:
CHECK: Avoid CamelCase: <pHT_info_ie>

Signed-off-by: Seonbin Yoon <seonbin.yoon0@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 4b4012411011..2116649bab6d 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -798,7 +798,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	int ret = _SUCCESS;
 	u8 *p;
 	u8 *ht_caps_ie = NULL;
-	u8 *pHT_info_ie = NULL;
+	u8 *p_ht_info_ie = NULL;
 	struct sta_info *psta = NULL;
 	u16 cap, ht_cap = false;
 	uint ie_len = 0;
@@ -1054,7 +1054,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		       &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
-		pHT_info_ie = p;
+		p_ht_info_ie = p;
 
 	switch (network_type) {
 	case WIRELESS_11B:
@@ -1091,7 +1091,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
+		HT_info_handler(padapter, (struct ndis_80211_var_ie *)p_ht_info_ie);
 	}
 
 	pbss_network->length =
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie

Posted by Dan Carpenter 1 month, 2 weeks ago

On Mon, Apr 27, 2026 at 06:18:33PM +0900, Seonbin Yoon wrote:
> Rename variable pHT_info_ie to p_ht_info_ie to comply with
> kernel coding style (snake_case).
> 
> Fixes the following checkpatch warning:
> CHECK: Avoid CamelCase: <pHT_info_ie>
> 
> Signed-off-by: Seonbin Yoon <seonbin.yoon0@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 4b4012411011..2116649bab6d 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -798,7 +798,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  	int ret = _SUCCESS;
>  	u8 *p;
>  	u8 *ht_caps_ie = NULL;
> -	u8 *pHT_info_ie = NULL;
> +	u8 *p_ht_info_ie = NULL;

p_ stands for pointer.  Get rid of that.  Just call it "ht_info_ie".

regards,
dan carpenter

[PATCH v2] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie

Posted by Seonbin Yoon 1 month, 2 weeks ago

Rename variable pHT_info_ie to ht_info_ie to comply with
kernel coding style (snake_case) and remove the unnecessary
pointer prefix.

Fixes the following checkpatch warning:
CHECK: Avoid CamelCase: <pHT_info_ie>

Signed-off-by: Seonbin Yoon <seonbin.yoon0@gmail.com>
---
v2: Remove the 'p_' prefix from the variable name as suggested by Dan Carpenter.
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 4b4012411011..36af7d07269b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -798,7 +798,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	int ret = _SUCCESS;
 	u8 *p;
 	u8 *ht_caps_ie = NULL;
-	u8 *pHT_info_ie = NULL;
+	u8 *ht_info_ie = NULL;
 	struct sta_info *psta = NULL;
 	u16 cap, ht_cap = false;
 	uint ie_len = 0;
@@ -1054,7 +1054,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		       &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
-		pHT_info_ie = p;
+		ht_info_ie = p;
 
 	switch (network_type) {
 	case WIRELESS_11B:
@@ -1091,7 +1091,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
+		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
 	}
 
 	pbss_network->length =
-- 
2.53.0

Re: [PATCH v2] staging: rtl8723bs: Fix CamelCase variable name pHT_info_ie

Posted by Greg KH 1 month, 1 week ago

On Mon, Apr 27, 2026 at 08:10:22PM +0900, Seonbin Yoon wrote:
> Rename variable pHT_info_ie to ht_info_ie to comply with
> kernel coding style (snake_case) and remove the unnecessary
> pointer prefix.
> 
> Fixes the following checkpatch warning:
> CHECK: Avoid CamelCase: <pHT_info_ie>
> 
> Signed-off-by: Seonbin Yoon <seonbin.yoon0@gmail.com>
> ---
> v2: Remove the 'p_' prefix from the variable name as suggested by Dan Carpenter.
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 4b4012411011..36af7d07269b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -798,7 +798,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  	int ret = _SUCCESS;
>  	u8 *p;
>  	u8 *ht_caps_ie = NULL;
> -	u8 *pHT_info_ie = NULL;
> +	u8 *ht_info_ie = NULL;
>  	struct sta_info *psta = NULL;
>  	u16 cap, ht_cap = false;
>  	uint ie_len = 0;
> @@ -1054,7 +1054,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  		       &ie_len,
>  		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
>  	if (p && ie_len > 0)
> -		pHT_info_ie = p;
> +		ht_info_ie = p;
>  
>  	switch (network_type) {
>  	case WIRELESS_11B:
> @@ -1091,7 +1091,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
>  
>  		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)ht_caps_ie);
>  
> -		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
> +		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
>  	}
>  
>  	pbss_network->length =
> -- 
> 2.53.0
> 
> 

Does not apply to my tree :(