[v1] net: Unify user-visible "Qualcomm" name

[PATCH] net: Unify user-visible "Qualcomm" name

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

Various names for Qualcomm as a company are used in user-visible config
options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
"Qualcomm" so it will be easier for users to identify the options when
for example running menuconfig.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

And "Qualcomm Technologies" has even variations over the tree:
Qualcomm Technologies
Qualcomm Technologies Inc.
Qualcomm Technologies, Inc.

I am doing this tree wide:
https://lore.kernel.org/all/?q=f%3Akrzysztof+s%3A%22Unify+user-visible%22+s%3AQualcomm
---
 drivers/net/ethernet/qualcomm/Kconfig | 4 ++--
 drivers/net/wwan/Kconfig              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index ba7efb108637..57e1984d20ee 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -48,7 +48,7 @@ config QCA7000_UART
 	  will be called qcauart.
 
 config QCOM_EMAC
-	tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
+	tristate "Qualcomm EMAC Gigabit Ethernet support"
 	depends on HAS_DMA && HAS_IOMEM
 	select CRC32
 	select PHYLIB
@@ -61,7 +61,7 @@ config QCOM_EMAC
 	  Precision Clock Synchronization Protocol.
 
 config QCOM_PPE
-	tristate "Qualcomm Technologies, Inc. PPE Ethernet support"
+	tristate "Qualcomm PPE Ethernet support"
 	depends on COMMON_CLK && HAS_IOMEM && OF
 	depends on ARCH_QCOM || COMPILE_TEST
 	select REGMAP_MMIO
diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
index 88df55d78d90..958dbc7347fa 100644
--- a/drivers/net/wwan/Kconfig
+++ b/drivers/net/wwan/Kconfig
@@ -38,7 +38,7 @@ config WWAN_HWSIM
 	  called wwan_hwsim.  If unsure, say N.
 
 config MHI_WWAN_CTRL
-	tristate "MHI WWAN control driver for QCOM-based PCIe modems"
+	tristate "MHI WWAN control driver for Qualcomm-based PCIe modems"
 	depends on MHI_BUS
 	help
 	  MHI WWAN CTRL allows QCOM-based PCIe modems to expose different modem
@@ -51,7 +51,7 @@ config MHI_WWAN_CTRL
 	  called mhi_wwan_ctrl.
 
 config MHI_WWAN_MBIM
-        tristate "MHI WWAN MBIM network driver for QCOM-based PCIe modems"
+        tristate "MHI WWAN MBIM network driver for Qualcomm-based PCIe modems"
         depends on MHI_BUS
         help
           MHI WWAN MBIM is a WWAN network driver for QCOM-based PCIe modems.
-- 
2.51.0

Re: [PATCH] net: Unify user-visible "Qualcomm" name

Posted by Simon Horman 1 month, 2 weeks ago

On Mon, Apr 27, 2026 at 09:01:27AM +0200, Krzysztof Kozlowski wrote:
> Various names for Qualcomm as a company are used in user-visible config
> options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
> "Qualcomm" so it will be easier for users to identify the options when
> for example running menuconfig.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

...

> diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
> index 88df55d78d90..958dbc7347fa 100644
> --- a/drivers/net/wwan/Kconfig
> +++ b/drivers/net/wwan/Kconfig
> @@ -38,7 +38,7 @@ config WWAN_HWSIM
>  	  called wwan_hwsim.  If unsure, say N.
>  
>  config MHI_WWAN_CTRL
> -	tristate "MHI WWAN control driver for QCOM-based PCIe modems"
> +	tristate "MHI WWAN control driver for Qualcomm-based PCIe modems"
>  	depends on MHI_BUS
>  	help
>  	  MHI WWAN CTRL allows QCOM-based PCIe modems to expose different modem

Hi Krzysztof,

Sashiko points out that QCOM is still used on the line above.

> @@ -51,7 +51,7 @@ config MHI_WWAN_CTRL
>  	  called mhi_wwan_ctrl.
>  
>  config MHI_WWAN_MBIM
> -        tristate "MHI WWAN MBIM network driver for QCOM-based PCIe modems"
> +        tristate "MHI WWAN MBIM network driver for Qualcomm-based PCIe modems"
>          depends on MHI_BUS
>          help
>            MHI WWAN MBIM is a WWAN network driver for QCOM-based PCIe modems.

And here too.

-- 
pw-bot: changes-requested

Re: [PATCH] net: Unify user-visible "Qualcomm" name

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 28/04/2026 18:14, Simon Horman wrote:
> On Mon, Apr 27, 2026 at 09:01:27AM +0200, Krzysztof Kozlowski wrote:
>> Various names for Qualcomm as a company are used in user-visible config
>> options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
>> "Qualcomm" so it will be easier for users to identify the options when
>> for example running menuconfig.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ...
> 
>> diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
>> index 88df55d78d90..958dbc7347fa 100644
>> --- a/drivers/net/wwan/Kconfig
>> +++ b/drivers/net/wwan/Kconfig
>> @@ -38,7 +38,7 @@ config WWAN_HWSIM
>>  	  called wwan_hwsim.  If unsure, say N.
>>  
>>  config MHI_WWAN_CTRL
>> -	tristate "MHI WWAN control driver for QCOM-based PCIe modems"
>> +	tristate "MHI WWAN control driver for Qualcomm-based PCIe modems"
>>  	depends on MHI_BUS
>>  	help
>>  	  MHI WWAN CTRL allows QCOM-based PCIe modems to expose different modem
> 
> Hi Krzysztof,
> 
> Sashiko points out that QCOM is still used on the line above.
> 
>> @@ -51,7 +51,7 @@ config MHI_WWAN_CTRL
>>  	  called mhi_wwan_ctrl.
>>  
>>  config MHI_WWAN_MBIM
>> -        tristate "MHI WWAN MBIM network driver for QCOM-based PCIe modems"
>> +        tristate "MHI WWAN MBIM network driver for Qualcomm-based PCIe modems"
>>          depends on MHI_BUS
>>          help
>>            MHI WWAN MBIM is a WWAN network driver for QCOM-based PCIe modems.
> 
> And here too.

Yes, I did not unify every single text because I believe that might be
more churn and not that much benefit. I think it is more important to
have a list of drivers in xconfig or menuconfig nicely organized and the
help message matters less.

But if you wish, I can replace it there as well.

Best regards,
Krzysztof

Re: [PATCH] net: Unify user-visible "Qualcomm" name

Posted by Simon Horman 1 month, 2 weeks ago

On Tue, Apr 28, 2026 at 06:28:24PM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2026 18:14, Simon Horman wrote:
> > On Mon, Apr 27, 2026 at 09:01:27AM +0200, Krzysztof Kozlowski wrote:
> >> Various names for Qualcomm as a company are used in user-visible config
> >> options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
> >> "Qualcomm" so it will be easier for users to identify the options when
> >> for example running menuconfig.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > 
> > ...
> > 
> >> diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig
> >> index 88df55d78d90..958dbc7347fa 100644
> >> --- a/drivers/net/wwan/Kconfig
> >> +++ b/drivers/net/wwan/Kconfig
> >> @@ -38,7 +38,7 @@ config WWAN_HWSIM
> >>  	  called wwan_hwsim.  If unsure, say N.
> >>  
> >>  config MHI_WWAN_CTRL
> >> -	tristate "MHI WWAN control driver for QCOM-based PCIe modems"
> >> +	tristate "MHI WWAN control driver for Qualcomm-based PCIe modems"
> >>  	depends on MHI_BUS
> >>  	help
> >>  	  MHI WWAN CTRL allows QCOM-based PCIe modems to expose different modem
> > 
> > Hi Krzysztof,
> > 
> > Sashiko points out that QCOM is still used on the line above.
> > 
> >> @@ -51,7 +51,7 @@ config MHI_WWAN_CTRL
> >>  	  called mhi_wwan_ctrl.
> >>  
> >>  config MHI_WWAN_MBIM
> >> -        tristate "MHI WWAN MBIM network driver for QCOM-based PCIe modems"
> >> +        tristate "MHI WWAN MBIM network driver for Qualcomm-based PCIe modems"
> >>          depends on MHI_BUS
> >>          help
> >>            MHI WWAN MBIM is a WWAN network driver for QCOM-based PCIe modems.
> > 
> > And here too.
> 
> Yes, I did not unify every single text because I believe that might be
> more churn and not that much benefit. I think it is more important to
> have a list of drivers in xconfig or menuconfig nicely organized and the
> help message matters less.
> 
> But if you wish, I can replace it there as well.

Thanks for clarifying.

I have no strong preference and am happy with this patch as-is.

Reviewed-by: Simon Horman <horms@kernel.org>

I see this was marked as changes requested.
Presumably due to my previous email.
Let's see if this helps.

pw-bot: under-review

Re: [PATCH] net: Unify user-visible "Qualcomm" name

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 27/04/2026 09:01, Krzysztof Kozlowski wrote:
> Various names for Qualcomm as a company are used in user-visible config
> options: QCOM, Qualcomm and Qualcomm Technologies.  Switch to unified
> "Qualcomm" so it will be easier for users to identify the options when
> for example running menuconfig.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> And "Qualcomm Technologies" has even variations over the tree:
> Qualcomm Technologies
> Qualcomm Technologies Inc.
> Qualcomm Technologies, Inc.
> 

Apologies, this is a duplicate - counting mistake.

Best regards,
Krzysztof