[v1] riscv/sifive: remove warning in errata

[PATCH] riscv/sifive: remove warning in errata

Posted by Yong-Xuan Wang 1 month, 3 weeks ago

The patch_id of the availability checking for SiFive vendor extensions
will always larger than ERRATA_SIFIVE_NUMBER. Remove this unnecessary
warning.

Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
---
 arch/riscv/errata/sifive/errata.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/errata/sifive/errata.c b/arch/riscv/errata/sifive/errata.c
index d0c61f86cba3..98edd9143321 100644
--- a/arch/riscv/errata/sifive/errata.c
+++ b/arch/riscv/errata/sifive/errata.c
@@ -94,7 +94,6 @@ void sifive_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
 		if (alt->vendor_id != SIFIVE_VENDOR_ID)
 			continue;
 		if (alt->patch_id >= ERRATA_SIFIVE_NUMBER) {
-			WARN(1, "This errata id:%d is not in kernel errata list", alt->patch_id);
 			continue;
 		}
 

---
base-commit: ddbf9c76c4020bf63a0799b00faad40caa3de6c2
change-id: 20260426-vendor-4b4427e0b670

Re: [PATCH] riscv/sifive: remove warning in errata

Posted by Conor Dooley 1 month, 2 weeks ago

On Sun, Apr 26, 2026 at 07:53:46PM -0700, Yong-Xuan Wang wrote:
> The patch_id of the availability checking for SiFive vendor extensions
> will always larger than ERRATA_SIFIVE_NUMBER. Remove this unnecessary
> warning.

I'm sorry, I don't quite understand this commit message. Where is the
other warning that makes this one unneeded?
I think the commit message needs to point out where that is.

Cheers,
Conor.

> 
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
> ---
>  arch/riscv/errata/sifive/errata.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/riscv/errata/sifive/errata.c b/arch/riscv/errata/sifive/errata.c
> index d0c61f86cba3..98edd9143321 100644
> --- a/arch/riscv/errata/sifive/errata.c
> +++ b/arch/riscv/errata/sifive/errata.c
> @@ -94,7 +94,6 @@ void sifive_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
>  		if (alt->vendor_id != SIFIVE_VENDOR_ID)
>  			continue;
>  		if (alt->patch_id >= ERRATA_SIFIVE_NUMBER) {
> -			WARN(1, "This errata id:%d is not in kernel errata list", alt->patch_id);
>  			continue;
>  		}
>  
> 
> ---
> base-commit: ddbf9c76c4020bf63a0799b00faad40caa3de6c2
> change-id: 20260426-vendor-4b4427e0b670
>

Re: [PATCH] riscv/sifive: remove warning in errata

Posted by Yong-Xuan Wang 1 month, 2 weeks ago

Hi Conor,

On Mon, Apr 27, 2026 at 11:12 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Sun, Apr 26, 2026 at 07:53:46PM -0700, Yong-Xuan Wang wrote:
> > The patch_id of the availability checking for SiFive vendor extensions
> > will always larger than ERRATA_SIFIVE_NUMBER. Remove this unnecessary
> > warning.
>
> I'm sorry, I don't quite understand this commit message. Where is the
> other warning that makes this one unneeded?
> I think the commit message needs to point out where that is.
>

Sorry it's my fault. I will update the commit message in the next version.

Regards,
Yong-Xuan

> Cheers,
> Conor.
>
> >
> > Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
> > ---
> >  arch/riscv/errata/sifive/errata.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/errata/sifive/errata.c b/arch/riscv/errata/sifive/errata.c
> > index d0c61f86cba3..98edd9143321 100644
> > --- a/arch/riscv/errata/sifive/errata.c
> > +++ b/arch/riscv/errata/sifive/errata.c
> > @@ -94,7 +94,6 @@ void sifive_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
> >               if (alt->vendor_id != SIFIVE_VENDOR_ID)
> >                       continue;
> >               if (alt->patch_id >= ERRATA_SIFIVE_NUMBER) {
> > -                     WARN(1, "This errata id:%d is not in kernel errata list", alt->patch_id);
> >                       continue;
> >               }
> >
> >
> > ---
> > base-commit: ddbf9c76c4020bf63a0799b00faad40caa3de6c2
> > change-id: 20260426-vendor-4b4427e0b670
> >