rtc: isl1208: Fix IRQ return value and wake reference leak

[PATCH 0/2] rtc: isl1208: Fix IRQ return value and wake reference leak

John Madieu posted 2 patches 1 month, 3 weeks ago

Download series mbox

drivers/rtc/rtc-isl1208.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH 0/2] rtc: isl1208: Fix IRQ return value and wake reference leak

Posted by John Madieu 1 month, 3 weeks ago

Hi all,

This series fixes two issues in rtc-isl1208. The first is
isl1208_rtc_interrupt() returning negative i2c errnos where
irqreturn_t is expected, which genirq flags as bogus and logs
on each IRQ. The second is a wake-reference leak: setup_irq()
calls enable_irq_wake() on success but the driver has no remove
path that balances it, so each rebind cycle leaks one wake
reference per IRQ.

John Madieu (2):
  rtc: isl1208: Fix returning errno as irqreturn_t in IRQ handler
  rtc: isl1208: Balance enable_irq_wake() with disable_irq_wake() on
    cleanup

 drivers/rtc/rtc-isl1208.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

-- 
2.25.1