[PATCH net v2 0/4] gve: Fixes for issues discovered via net selftests

Harshitha Ramamurthy posted 4 patches 1 month, 3 weeks ago
drivers/net/ethernet/google/gve/gve.h        |   7 +
drivers/net/ethernet/google/gve/gve_adminq.c |   4 +-
drivers/net/ethernet/google/gve/gve_main.c   | 152 ++++++++++++++-----
3 files changed, 125 insertions(+), 38 deletions(-)
[PATCH net v2 0/4] gve: Fixes for issues discovered via net selftests
Posted by Harshitha Ramamurthy 1 month, 3 weeks ago
From: Pin-yen Lin <treapking@google.com>

This patch series addresses several issues in the gve driver. All four of
these fixes were uncovered by running the net selftests.

The series includes the following changes:

- Patch 1 adds NULL pointer checks for the per-queue statistics code to
  prevent crashes when the rings are queried while the link is down. This
  was discovered by the drivers/net/stats.py selftest.
- Patch 2 fixes an issue where interface stats would go backwards when the
  interface was brought down or its configuration was adjusted. This was
  also discovered by the drivers/net/stats.py selftest.
- Patch 3 ensures the driver falls back to the default minimum ring size if
  the corresponding device option values are exposed as 0. This prevents
  userspace from configuring unexpectedly small ring sizes. This was
  discovered by the drivers/net/ring_reconfig.py selftest.
- Patch 4 makes sure ethtool configuration modifications are done
  synchronously before returning to the userspace. This was discovered by
  the drivers/net/ping.py selftest.


Changes in v2:
- Link to v1: https://lore.kernel.org/netdev/20260420171837.455487-1-hramamurthy@google.com/
- Add a NULL pointer check in gve_get_ring_err_stats() (Sashiko)
- Use local variable to prevent inflates from u64_stats_fetch_retry()
  (Sashiko)
- Add u64_stats_fetch/begin to protect base stats (Sashiko)

Debarghya Kundu (2):
  gve: Add NULL pointer checks for per-queue statistics
  gve: Fix backward stats when interface goes down or configuration is
    adjusted

Pin-yen Lin (2):
  gve: Use default min ring size when device option values are 0
  gve: Make ethtool config changes synchronous

 drivers/net/ethernet/google/gve/gve.h        |   7 +
 drivers/net/ethernet/google/gve/gve_adminq.c |   4 +-
 drivers/net/ethernet/google/gve/gve_main.c   | 152 ++++++++++++++-----
 3 files changed, 125 insertions(+), 38 deletions(-)

-- 
2.54.0.rc2.544.gc7ae2d5bb8-goog

base-commit: e728258debd553c95d2e70f9cd97c9fde27c7130
branch: gve-misc-fixes