[PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler

Mohamed Ayman posted 1 patch 1 month, 3 weeks ago
drivers/gpio/gpio-ep93xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
Posted by Mohamed Ayman 1 month, 3 weeks ago
Replace the temporary fallback handle_simple_irq with handle_bad_irq
now that the driver operates with a proper hierarchical IRQ setup.
This ensures unexpected or unmapped interrupts are clearly flagged
instead of being silently handled.

Signed-off-by: Mohamed Ayman <mohamedaymanworkspace@gmail.com>
---
 drivers/gpio/gpio-ep93xx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 1f56e44ffc9a..8784e433e1ff 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -323,8 +323,7 @@ static int ep93xx_setup_irqs(struct platform_device *pdev,
 	}
 
 	girq->default_type = IRQ_TYPE_NONE;
-	/* TODO: replace with handle_bad_irq() once we are fully hierarchical */
-	girq->handler = handle_simple_irq;
+	girq->handler = handle_bad_irq;
 
 	return 0;
 }
-- 
2.34.1
Re: [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
Posted by Bartosz Golaszewski 1 month, 3 weeks ago
On Fri, 24 Apr 2026 14:59:20 +0300, Mohamed Ayman wrote:
> Replace the temporary fallback handle_simple_irq with handle_bad_irq
> now that the driver operates with a proper hierarchical IRQ setup.
> This ensures unexpected or unmapped interrupts are clearly flagged
> instead of being silently handled.
> 
> 

Applied, thanks!

[1/1] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
      https://git.kernel.org/brgl/c/42509588db15100732f236b6a007f384dde3833f

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH] gpio: ep93xx: use handle_bad_irq() as default IRQ handler
Posted by Linus Walleij 1 month, 3 weeks ago
On Fri, Apr 24, 2026 at 1:59 PM Mohamed Ayman
<mohamedaymanworkspace@gmail.com> wrote:

> Replace the temporary fallback handle_simple_irq with handle_bad_irq
> now that the driver operates with a proper hierarchical IRQ setup.
> This ensures unexpected or unmapped interrupts are clearly flagged
> instead of being silently handled.
>
> Signed-off-by: Mohamed Ayman <mohamedaymanworkspace@gmail.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij