staging: media: atomisp: pci: runtime: debug: src: remove curly braces for single line if

[PATCH] staging: media: atomisp: pci: runtime: debug: src: remove curly braces for single line if

Posted by Johts 1 month, 3 weeks ago

Fix checkpath error "WARNING: braces {} are not necessary for single statement blocks" in sh_css_params.c:1931

Signed-off-by: Johts <johatanrlima@gmail.com>
---
 drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
index fcebace11daf..31426001864e 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_params.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
@@ -1928,10 +1928,8 @@ sh_css_set_per_frame_isp_config_on_pipe(
 	params = stream->per_frame_isp_params_configs;
 
 	/* update new ISP params object with the new config */
-	if (!sh_css_init_isp_params_from_global(stream, params, false, pipe)) {
-		err1 = -EINVAL;
-	}
-
+	if (!sh_css_init_isp_params_from_global(stream, params, false, pipe))	err1 = -EINVAL;
+	
 	err2 = sh_css_init_isp_params_from_config(stream->pipes[0], params, config, pipe);
 
 	if (per_frame_config_created) {
-- 
2.43.0

Re: [PATCH] staging: media: atomisp: pci: runtime: debug: src: remove curly braces for single line if

Posted by Sakari Ailus 1 month, 3 weeks ago

Hi Johts,

On Thu, Apr 23, 2026 at 03:45:40PM -0300, Johts wrote:
> Fix checkpath error "WARNING: braces {} are not necessary for single statement blocks" in sh_css_params.c:1931
> 
> Signed-off-by: Johts <johatanrlima@gmail.com>

We need a more specific name here.

> ---
>  drivers/staging/media/atomisp/pci/sh_css_params.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
> index fcebace11daf..31426001864e 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_params.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
> @@ -1928,10 +1928,8 @@ sh_css_set_per_frame_isp_config_on_pipe(
>  	params = stream->per_frame_isp_params_configs;
>  
>  	/* update new ISP params object with the new config */
> -	if (!sh_css_init_isp_params_from_global(stream, params, false, pipe)) {
> -		err1 = -EINVAL;
> -	}
> -
> +	if (!sh_css_init_isp_params_from_global(stream, params, false, pipe))	err1 = -EINVAL;

Please run checkpatch.pl on this.

> +	
>  	err2 = sh_css_init_isp_params_from_config(stream->pipes[0], params, config, pipe);
>  
>  	if (per_frame_config_created) {

-- 
Regards,

Sakari Ailus