x86/bug: Add printf() validation to x86's custom WARNs

[PATCH v2 0/2] x86/bug: Add printf() validation to x86's custom WARNs

Sean Christopherson posted 2 patches 1 month, 3 weeks ago

Download series mbox

arch/x86/include/asm/bug.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 0/2] x86/bug: Add printf() validation to x86's custom WARNs

Posted by Sean Christopherson 1 month, 3 weeks ago

In x86's custom HAVE_ARCH_BUG_FORMAT_ARGS WARNs, invoke a dummy function
with __printf() annotation to validate the formatting+arguments of any
provided messages.

Yan reported a bug where I botched the formatting of a WARN_ONCE() argument,
but none of my builds (with W=1 and -Werror) detected the issue, nor did any
of the build bots (AFAIK).  Turns out that Yan found it via CONFIG_BUG=n,
which due to the code being 64-bit-only, was the only way to detect the
malformed message.

v2:
 - Drop the dummy macro for assembly code. [Yan]
 - Extend the #ifdeffery to hide the WARN macros themselves from assembly
   code. [Yan]

v1: https://lore.kernel.org/all/20260409182941.1912856-1-seanjc@google.com

Sean Christopherson (2):
  x86/bug: Add printf() validation to HAVE_ARCH_BUG_FORMAT_ARGS WARNs
  x86/bug: Put HAVE_ARCH_BUG_FORMAT_ARGS WARN definitions inside
    __ASSEMBLER__

 arch/x86/include/asm/bug.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 59287e6ad4a9e5d13519b783d6bbc1015b94d63e
-- 
2.54.0.545.g6539524ca2-goog