selinux: use QSTR() instead of QSTR_INIT() in init_sel_fs

[PATCH] selinux: use QSTR() instead of QSTR_INIT() in init_sel_fs

Posted by Thorsten Blum 1 month, 3 weeks ago

Drop the length argument and use the simpler QSTR().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 security/selinux/selinuxfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 83aa765a09f9..8c107af5140e 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -2107,8 +2107,7 @@ struct path selinux_null __ro_after_init;
 
 int __init init_sel_fs(void)
 {
-	struct qstr null_name = QSTR_INIT(NULL_FILE_NAME,
-					  sizeof(NULL_FILE_NAME)-1);
+	struct qstr null_name = QSTR(NULL_FILE_NAME);
 	int err;
 
 	if (!selinux_enabled_boot)

Re: [PATCH] selinux: use QSTR() instead of QSTR_INIT() in init_sel_fs

Posted by Paul Moore 1 month, 2 weeks ago

On Apr 22, 2026 Thorsten Blum <thorsten.blum@linux.dev> wrote:
> 
> Drop the length argument and use the simpler QSTR().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  security/selinux/selinuxfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 83aa765a09f9..8c107af5140e 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -2107,8 +2107,7 @@ struct path selinux_null __ro_after_init;
>  
>  int __init init_sel_fs(void)
>  {
> -	struct qstr null_name = QSTR_INIT(NULL_FILE_NAME,
> -					  sizeof(NULL_FILE_NAME)-1);
> +	struct qstr null_name = QSTR(NULL_FILE_NAME);
>  	int err;
>  
>  	if (!selinux_enabled_boot)

Technically I imagine QSTR_INIT() would be slightly quicker since we use
sizeof() instead of strlen(), but the code is simpler and I can't we only
pay the performance hit once at boot.

Merged into selinux/dev, thanks.

--
paul-moore.com