drivers/iio/magnetometer/ak8975.c | 92 +++++++++++++++---------------- 1 file changed, 45 insertions(+), 47 deletions(-)
This series modernizes and cleans up the ak8975 driver, migrating to
more modern kernel APIs and cleaning up legacy code.
Changes include:
- replacing usleep_range() with fsleep() for optimization
- migrating to iopoll macros for better device polling
- removing unused headers and adding new ones
- checkpatch.pl fixes
v2:
- PATCH 1: reverted alphabetical header ordering per logical change
separation
- PATCH 2: added newline between fsleep() and return
- PATCH 3: fixed open parenthesis formatting
- PATCH 4: fixed whitespace issues, added <linux/time.h> for
USEC_PER_MSEC macro
v3:
- PATCH 1 & 2: split alphabetical ordering and header removal into two
separate patches
- PATCH 4: commit message fix
- PATCH 5 & 6: split error handling and polling loop replacement into
two separate patches
Joshua Crofts (6):
iio: magnetometer: ak8975: sort headers alphabetically
iio: magnetometer: ak8975: remove unused headers
iio: magnetometer: ak8975: replace usleep_range() with fsleep()
iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast
iio: magnetometer: ak8975: fix wrong errno on return
iio: magnetometer: ak8975: modernize polling loops with iopoll()
macros
drivers/iio/magnetometer/ak8975.c | 92 +++++++++++++++----------------
1 file changed, 45 insertions(+), 47 deletions(-)
base-commit: c65f27cae0deda3316ed49899df4492a3896e38c
--
2.47.3
On Wed, Apr 22, 2026 at 11:22:01AM +0000, Joshua Crofts wrote: > This series modernizes and cleans up the ak8975 driver, migrating to > more modern kernel APIs and cleaning up legacy code. > > Changes include: > - replacing usleep_range() with fsleep() for optimization > - migrating to iopoll macros for better device polling > - removing unused headers and adding new ones > - checkpatch.pl fixes 5 out of 6 are good, one needs a bit more as it's a new patch in this version. Also, wait a bit I'll send a couple more that you may incorporate in your series. Btw, are you familiar with `b4` tool? If not, good time to start playing with it. -- With Best Regards, Andy Shevchenko
On Wed, 22 Apr 2026 at 15:16, Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > 5 out of 6 are good, one needs a bit more as it's a new patch in this version. > Also, wait a bit I'll send a couple more that you may incorporate in your > series. Btw, are you familiar with `b4` tool? If not, good time to start > playing with it. Just checking in on this, since I haven't seen any changes on lore. Btw, b4 really does save *a lot* of time. -- Kind regards CJD
On Fri, Apr 24, 2026 at 10:23:31AM +0200, Joshua Crofts wrote: > On Wed, 22 Apr 2026 at 15:16, Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > 5 out of 6 are good, one needs a bit more as it's a new patch in this version. > > Also, wait a bit I'll send a couple more that you may incorporate in your > > series. Btw, are you familiar with `b4` tool? If not, good time to start > > playing with it. > > Just checking in on this, since I haven't seen any changes on lore. Sorry for the delay (if you want to help, start reviewing others' patches in IIO mailing list, you also learn from that). Now when I got my email pipeline clean, I am about to start doing what's been promised. > Btw, b4 really does save *a lot* of time. -- With Best Regards, Andy Shevchenko
On Fri, 24 Apr 2026 at 12:18, Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > Sorry for the delay (if you want to help, start reviewing others' patches in > IIO mailing list, you also learn from that). Now when I got my email pipeline > clean, I am about to start doing what's been promised. I wasn't sure that I can just start reviewing, so good to know. No worries about the delay. -- Kind regards CJD
On Fri, Apr 24, 2026 at 12:23:09PM +0200, Joshua Crofts wrote: > On Fri, 24 Apr 2026 at 12:18, Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > Sorry for the delay (if you want to help, start reviewing others' patches in > > IIO mailing list, you also learn from that). Now when I got my email pipeline > > clean, I am about to start doing what's been promised. > > I wasn't sure that I can just start reviewing, so good to know. No worries about > the delay. FWIW, just send what I promised to send, this driver is a rabbit hole... See 20260427201412.3067235-1-andriy.shevchenko@linux.intel.com. -- With Best Regards, Andy Shevchenko
On Fri, 24 Apr 2026 12:23:09 +0200 Joshua Crofts <joshua.crofts1@gmail.com> wrote: > On Fri, 24 Apr 2026 at 12:18, Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > Sorry for the delay (if you want to help, start reviewing others' patches in > > IIO mailing list, you also learn from that). Now when I got my email pipeline > > clean, I am about to start doing what's been promised. > > I wasn't sure that I can just start reviewing, so good to know. No worries about > the delay. > FWIW I took a look through and have nothing to add. Looking forward to v4. How Andy manage to catch up with is backlog is beyond me :) Jonathan
On Fri, 24 Apr 2026 at 20:02, Jonathan Cameron <jic23@kernel.org> wrote: > FWIW I took a look through and have nothing to add. Looking forward to v4. > How Andy manage to catch up with is backlog is beyond me :) Sure is impressive judging by the amount of patches that come in daily :) -- Kind regards CJD
On Wed, 22 Apr 2026 at 15:16, Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > 5 out of 6 are good, one needs a bit more as it's a new patch in this version. Considering this is my second patch series, I'll take this as a compliment :) > Also, wait a bit I'll send a couple more that you may incorporate in your > series. Btw, are you familiar with `b4` tool? If not, good time to start > playing with it. Only a little bit, I only really do 'b4 am' on patches but I'll check out the manual a bit more. -- Kind regards CJD
© 2016 - 2026 Red Hat, Inc.