dt-bindings: arm-smmu: qcom:: Fix Hawi compatible placement

[PATCH] dt-bindings: arm-smmu: qcom:: Fix Hawi compatible placement

Posted by Mukesh Ojha 1 month, 4 weeks ago

qcom,hawi-smmu-500 was placed in the wrong enum block of GPU. Move it to
the correct location alongside other Qualcomm SMMU-500 compatibles for
CPU.

Fixes: 5e8323c3d528 ("dt-bindings: arm-smmu: qcom: Add compatible for Hawi SoC")
Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 06fb5c8e7547..ba9ad1f5a8ff 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -37,6 +37,7 @@ properties:
           - enum:
               - qcom,eliza-smmu-500
               - qcom,glymur-smmu-500
+              - qcom,hawi-smmu-500
               - qcom,kaanapali-smmu-500
               - qcom,milos-smmu-500
               - qcom,qcm2290-smmu-500
@@ -93,7 +94,6 @@ properties:
         items:
           - enum:
               - qcom,glymur-smmu-500
-              - qcom,hawi-smmu-500
               - qcom,kaanapali-smmu-500
               - qcom,milos-smmu-500
               - qcom,qcm2290-smmu-500
-- 
2.53.0

Re: [PATCH] dt-bindings: arm-smmu: qcom:: Fix Hawi compatible placement

Posted by Krzysztof Kozlowski 1 month, 4 weeks ago

On 22/04/2026 10:33, Mukesh Ojha wrote:
> qcom,hawi-smmu-500 was placed in the wrong enum block of GPU. Move it to
> the correct location alongside other Qualcomm SMMU-500 compatibles for
> CPU.

How could it pass dtbs_check?

> 
> Fixes: 5e8323c3d528 ("dt-bindings: arm-smmu: qcom: Add compatible for Hawi SoC")
> Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 06fb5c8e7547..ba9ad1f5a8ff 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -37,6 +37,7 @@ properties:
>            - enum:
>                - qcom,eliza-smmu-500
>                - qcom,glymur-smmu-500
> +              - qcom,hawi-smmu-500
>                - qcom,kaanapali-smmu-500
>                - qcom,milos-smmu-500
>                - qcom,qcm2290-smmu-500
> @@ -93,7 +94,6 @@ properties:
>          items:
>            - enum:
>                - qcom,glymur-smmu-500
> -              - qcom,hawi-smmu-500

No, why? That's for GPU. Why are you moving GPU compatible to non-GPU place?



Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm-smmu: qcom:: Fix Hawi compatible placement

Posted by Mukesh Ojha 1 month, 4 weeks ago

On Wed, Apr 22, 2026 at 11:04:09AM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2026 10:33, Mukesh Ojha wrote:
> > qcom,hawi-smmu-500 was placed in the wrong enum block of GPU. Move it to
> > the correct location alongside other Qualcomm SMMU-500 compatibles for
> > CPU.
> 
> How could it pass dtbs_check?

It was bad on my part.

> > 
> > Fixes: 5e8323c3d528 ("dt-bindings: arm-smmu: qcom: Add compatible for Hawi SoC")
> > Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> > ---
> >  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > index 06fb5c8e7547..ba9ad1f5a8ff 100644
> > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> > @@ -37,6 +37,7 @@ properties:
> >            - enum:
> >                - qcom,eliza-smmu-500
> >                - qcom,glymur-smmu-500
> > +              - qcom,hawi-smmu-500
> >                - qcom,kaanapali-smmu-500
> >                - qcom,milos-smmu-500
> >                - qcom,qcm2290-smmu-500
> > @@ -93,7 +94,6 @@ properties:
> >          items:
> >            - enum:
> >                - qcom,glymur-smmu-500
> > -              - qcom,hawi-smmu-500
> 
> No, why? That's for GPU. Why are you moving GPU compatible to non-GPU place?

Earlier commit was meant for CPUs and not for GPUs, hence moving it Or,
Are you saying do not do the movement and add one for CPUs ?

> 
> 
> Best regards,
> Krzysztof

-- 
-Mukesh Ojha

Re: [PATCH] dt-bindings: arm-smmu: qcom:: Fix Hawi compatible placement

Posted by Krzysztof Kozlowski 1 month, 4 weeks ago

On 22/04/2026 16:27, Mukesh Ojha wrote:
>>>            - enum:
>>>                - qcom,eliza-smmu-500
>>>                - qcom,glymur-smmu-500
>>> +              - qcom,hawi-smmu-500
>>>                - qcom,kaanapali-smmu-500
>>>                - qcom,milos-smmu-500
>>>                - qcom,qcm2290-smmu-500
>>> @@ -93,7 +94,6 @@ properties:
>>>          items:
>>>            - enum:
>>>                - qcom,glymur-smmu-500
>>> -              - qcom,hawi-smmu-500
>>
>> No, why? That's for GPU. Why are you moving GPU compatible to non-GPU place?
> 
> Earlier commit was meant for CPUs and not for GPUs, hence moving it Or,

OK, but:

> Are you saying do not do the movement and add one for CPUs ?

yeah, because you might need it in this place for the GPU. Therefore I
would propose to check what compatible you expect for the GPU part and
just add it.

Best regards,
Krzysztof