arm64: dts: renesas: rz-smarc-du-adv7513: Simplify DU port configuration

[PATCH] arm64: dts: renesas: rz-smarc-du-adv7513: Simplify DU port configuration

Posted by Prabhakar 1 month, 3 weeks ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

The SoC dtsi already defines the du node with its ports hierarchy,
including the du_out_rgb endpoint node under port@0. There is no need
to redefine the entire ports/port@0 structure in the board-level dtsi.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../boot/dts/renesas/rz-smarc-du-adv7513.dtsi     | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi b/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
index f5412578ee65..dbe16908b260 100644
--- a/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
+++ b/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
@@ -24,19 +24,10 @@ &du {
 	pinctrl-names = "default";
 
 	status = "okay";
+};
 
-	ports {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		port@0 {
-			reg = <0>;
-
-			du_out_rgb: endpoint {
-				remote-endpoint = <&adv7513_in>;
-			};
-		};
-	};
+&du_out_rgb {
+	remote-endpoint = <&adv7513_in>;
 };
 
 &ADV7513_PARENT_I2C {
-- 
2.53.0

Re: [PATCH] arm64: dts: renesas: rz-smarc-du-adv7513: Simplify DU port configuration

Posted by Geert Uytterhoeven 3 weeks, 4 days ago

On Mon, 20 Apr 2026 at 15:22, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The SoC dtsi already defines the du node with its ports hierarchy,
> including the du_out_rgb endpoint node under port@0. There is no need
> to redefine the entire ports/port@0 structure in the board-level dtsi.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v7.2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: rz-smarc-du-adv7513: Simplify DU port configuration

Posted by Geert Uytterhoeven 1 month, 3 weeks ago

Hi Prabhkar,

On Mon, 20 Apr 2026 at 15:22, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The SoC dtsi already defines the du node with its ports hierarchy,
> including the du_out_rgb endpoint node under port@0. There is no need
> to redefine the entire ports/port@0 structure in the board-level dtsi.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
> @@ -24,19 +24,10 @@ &du {
>         pinctrl-names = "default";
>
>         status = "okay";
> +};
>
> -       ports {
> -               #address-cells = <1>;
> -               #size-cells = <0>;
> -
> -               port@0 {
> -                       reg = <0>;
> -
> -                       du_out_rgb: endpoint {
> -                               remote-endpoint = <&adv7513_in>;
> -                       };
> -               };
> -       };
> +&du_out_rgb {
> +       remote-endpoint = <&adv7513_in>;
>  };
>
>  &ADV7513_PARENT_I2C {

Doesn't this introduce new DTC W=1 warnings?
Cfr. "[PATCH 0/4] arm64: dts: renesas: Fix missing cells and reg"
https://lore.kernel.org/20260326042411.215241-1-marek.vasut+renesas@mailbox.org/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: rz-smarc-du-adv7513: Simplify DU port configuration

Posted by Lad, Prabhakar 1 month, 3 weeks ago

Hi Geert,

On Mon, Apr 20, 2026 at 2:39 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhkar,
>
> On Mon, 20 Apr 2026 at 15:22, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > The SoC dtsi already defines the du node with its ports hierarchy,
> > including the du_out_rgb endpoint node under port@0. There is no need
> > to redefine the entire ports/port@0 structure in the board-level dtsi.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rz-smarc-du-adv7513.dtsi
> > @@ -24,19 +24,10 @@ &du {
> >         pinctrl-names = "default";
> >
> >         status = "okay";
> > +};
> >
> > -       ports {
> > -               #address-cells = <1>;
> > -               #size-cells = <0>;
> > -
> > -               port@0 {
> > -                       reg = <0>;
> > -
> > -                       du_out_rgb: endpoint {
> > -                               remote-endpoint = <&adv7513_in>;
> > -                       };
> > -               };
> > -       };
> > +&du_out_rgb {
> > +       remote-endpoint = <&adv7513_in>;
> >  };
> >
> >  &ADV7513_PARENT_I2C {
>
> Doesn't this introduce new DTC W=1 warnings?
> Cfr. "[PATCH 0/4] arm64: dts: renesas: Fix missing cells and reg"
> https://lore.kernel.org/20260326042411.215241-1-marek.vasut+renesas@mailbox.org/
>
No it does not introduce new warnings (logs [1]) as the SoC DTSI
already has the missing cells and reg properties [2].

[1] https://gist.github.com/prabhakarlad/69f53e32faee17ead390c9ed68c322d3
[2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/renesas/r9a07g043u.dtsi?h=next-20260420#n169

Cheers,
Prabhakar