1. Patchew
  2. linux
  3. View series

[PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c

Sandie Cao posted 1 patch 2 months ago 
arch/riscv/boot/dts/spacemit/k3.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
[PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Sandie Cao 2 months ago 
Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/

Signed-off-by: Sandie Cao <sandie.cao@deepcomputing.io>
---
 arch/riscv/boot/dts/spacemit/k3.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
index 815debd16409..9a3d2e8cdfe8 100644
--- a/arch/riscv/boot/dts/spacemit/k3.dtsi
+++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
@@ -556,7 +556,7 @@ gmac2_axi_setup: stmmac-axi-config {
 		};
 
 		i2c0: i2c@d4010800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4010800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -570,7 +570,7 @@ i2c0: i2c@d4010800 {
 		};
 
 		i2c1: i2c@d4011000 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4011000 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -584,7 +584,7 @@ i2c1: i2c@d4011000 {
 		};
 
 		i2c2: i2c@d4012000 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4012000 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -598,7 +598,7 @@ i2c2: i2c@d4012000 {
 		};
 
 		i2c4: i2c@d4012800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4012800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -612,7 +612,7 @@ i2c4: i2c@d4012800 {
 		};
 
 		i2c5: i2c@d4013800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4013800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -752,7 +752,7 @@ uart9: serial@d4017800 {
 		};
 
 		i2c6: i2c@d4018800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd4018800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -784,7 +784,7 @@ gpio: gpio@d4019000 {
 		};
 
 		i2c8: i2c@d401d800 {
-			compatible = "spacemit,k3-i2c", "spacemit,k1-i2c";
+			compatible = "spacemit,k1-i2c";
 			reg = <0x0 0xd401d800 0x0 0x38>;
 			#address-cells = <1>;
 			#size-cells = <0>;
-- 
2.43.0
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Krzysztof Kozlowski 2 months ago 
On 20/04/2026 10:39, Sandie Cao wrote:
> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected

Missing space after main commit msg.

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> 

There is no space between tags.

Anyway, explain WHY K3 device does not use K3 compatible. It is clearly
violating writing-bindings.

Plus, I don't think this report is correct. You just send us something
close to random fix of random warning, without even opening the files
and understanding what is there. spacemit,k3-i2c MUST be used with K1.
Please read the binding.

NAK

Best regards,
Krzysztof
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Krzysztof Kozlowski 2 months ago 
On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> On 20/04/2026 10:39, Sandie Cao wrote:
>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> 
> Missing space after main commit msg.
> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>>

Also, the file reported in above warning DOES NOT EXIST (I checked
next-20260414).

Please do not send reported-by bug reports for things which do not exist.

Best regards,
Krzysztof
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Troy Mitchell 2 months ago 
On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
>> On 20/04/2026 10:39, Sandie Cao wrote:
>>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
>> 
>> Missing space after main commit msg.
>> 
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>>>
>
> Also, the file reported in above warning DOES NOT EXIST (I checked
> next-20260414).
In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:

properties:
  compatible:
    enum:
      - spacemit,k1-pinctrl
      - spacemit,k3-pinctrl

So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
there are subtle differences between them.

                                  - Troy
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Yixun Lan 2 months ago 
Hi Troy,

On 16:50 Mon 20 Apr     , Troy Mitchell wrote:
> On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> >> On 20/04/2026 10:39, Sandie Cao wrote:
> >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> >> 
> >> Missing space after main commit msg.
> >> 
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> >>>
> >
> > Also, the file reported in above warning DOES NOT EXIST (I checked
> > next-20260414).
> In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
> 
> properties:
>   compatible:
>     enum:
>       - spacemit,k1-pinctrl
>       - spacemit,k3-pinctrl
> 
I think you refer to wrong file, which should be
 Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml

> So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
> there are subtle differences between them.
> 
But yes, the idea is correct, so NAK to this patch
>                                   - Troy

-- 
Yixun Lan (dlan)
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Troy Mitchell 2 months ago 
On Mon Apr 20, 2026 at 5:09 PM CST, Yixun Lan wrote:
> Hi Troy,
>
> On 16:50 Mon 20 Apr     , Troy Mitchell wrote:
>> On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
>> > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
>> >> On 20/04/2026 10:39, Sandie Cao wrote:
>> >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
>> >> 
>> >> Missing space after main commit msg.
>> >> 
>> >>> Reported-by: kernel test robot <lkp@intel.com>
>> >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>> >>>
>> >
>> > Also, the file reported in above warning DOES NOT EXIST (I checked
>> > next-20260414).
>> In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
>> 
>> properties:
>>   compatible:
>>     enum:
>>       - spacemit,k1-pinctrl
>>       - spacemit,k3-pinctrl
>> 
> I think you refer to wrong file, which should be
>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
My apologies, I overlooked that. The file you mentioned is indeed correct.
Thanks for pointing it out.

                                        - Troy
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Sandie Cao 2 months ago 
Hi, Lan & Troy & Krzysztof :

> From: "Yixun Lan"<dlan@kernel.org>
> Date:  Mon, Apr 20, 2026, 17:09

> Hi Troy,
> 
> On 16:50 Mon 20 Apr     , Troy Mitchell wrote:
> > On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> > > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> > >> On 20/04/2026 10:39, Sandie Cao wrote:
> > >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> > >> 
> > >> Missing space after main commit msg.
> > >> 
> > >>> Reported-by: kernel test robot <lkp@intel.com>
> > >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> > >>>
> > >
> > > Also, the file reported in above warning DOES NOT EXIST (I checked
> > > next-20260414).
> > In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
> > 
> > properties:
> >   compatible:
> >     enum:
> >       - spacemit,k1-pinctrl
> >       - spacemit,k3-pinctrl
> > 
> I think you refer to wrong file, which should be
>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> 
> > So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
> > there are subtle differences between them.
> > 
> But yes, the idea is correct, so NAK to this patch
> >                                   - Troy
> 
> -- 
> Yixun Lan (dlan)
> 

Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. 
And it meets dtscheck issue:
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/

On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml.
Or I use the wrong branch? 

And what should I do for my patch[1] ?  

[1] https://lore.kernel.org/all/20260413060524.1235982-1-sandie.cao@deepcomputing.io/
[2] https://github.com/spacemit-com/linux/tree/k1/for-next#

Best regards
Sandie
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Krzysztof Kozlowski 2 months ago 
On 20/04/2026 11:26, Sandie Cao wrote:
> 
> Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. 
> And it meets dtscheck issue:
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
> 
> On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml.
> Or I use the wrong branch? 
> 
> And what should I do for my patch[1] ?  

Test your patch on linux-next. See also maintainer-soc and
maintainer-soc-clean-dts profiles in kernel.


Best regards,
Krzysztof
Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
Posted by Troy Mitchell 2 months ago 
On Mon Apr 20, 2026 at 5:26 PM CST, Sandie Cao wrote:
> Hi, Lan & Troy & Krzysztof :
>
>> From: "Yixun Lan"<dlan@kernel.org>
>> Date:  Mon, Apr 20, 2026, 17:09
>
>> Hi Troy,
>> 
>> On 16:50 Mon 20 Apr     , Troy Mitchell wrote:
>> > On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
>> > > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
>> > >> On 20/04/2026 10:39, Sandie Cao wrote:
>> > >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
>> > >> 
>> > >> Missing space after main commit msg.
>> > >> 
>> > >>> Reported-by: kernel test robot <lkp@intel.com>
>> > >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>> > >>>
>> > >
>> > > Also, the file reported in above warning DOES NOT EXIST (I checked
>> > > next-20260414).
>> > In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
>> > 
>> > properties:
>> >   compatible:
>> >     enum:
>> >       - spacemit,k1-pinctrl
>> >       - spacemit,k3-pinctrl
>> > 
>> I think you refer to wrong file, which should be
>>  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
>> 
>> > So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
>> > there are subtle differences between them.
>> > 
>> But yes, the idea is correct, so NAK to this patch
>> >                                   - Troy
>> 
>> -- 
>> Yixun Lan (dlan)
>> 
>
> Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree.  The patch is based on k1/dt-for-next[2]. 
> And it meets dtscheck issue:
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@intel.com/
>
> On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml.
> Or I use the wrong branch? 
Yes... You are using a wrong branch I think. 
The k1/dt-for-next branch in this repo is Dlan’s tree. Since DT bindings are not within
his purview, they aren't included there. I only mentioned this repository earlier to
show that the UART portion of the pinctrl dtsi has already been merged into it;
it wasn't intended to be used as your development base.
>
> And what should I do for my patch[1] ?  
I think you can use next-20260417 as your base commit.
Everything you need is available here.

                                      - Troy
>
> [1] https://lore.kernel.org/all/20260413060524.1235982-1-sandie.cao@deepcomputing.io/
> [2] https://github.com/spacemit-com/linux/tree/k1/for-next#
>
> Best regards
> Sandie

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.