1. Patchew
  2. linux
  3. View series

[PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration

Yuho Choi posted 1 patch 1 month, 3 weeks ago 
drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
1 file changed, 1 deletion(-)
[PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Posted by Yuho Choi 1 month, 3 weeks ago 
DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
shadowing the existing function-local variable. Drop the inner declaration
and reuse the existing variable to avoid unnecessary shadowing.

Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Co-developed-by: Ijae Kim <ae878000@gmail.com>
Signed-off-by: Ijae Kim <ae878000@gmail.com>
Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 337671b1211f0..cf5698dda91fc 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 			precvpriv->rx_drop++;
 		} else if (retval == _SUCCESS) {
 #ifdef DBG_RX_DUMP_EAP
-			u8 bDumpRxPkt;
 			u16 eth_type;
 
 			/*  dump eapol */
-- 
2.50.1 (Apple Git-155)
Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Posted by Ethan Tidmore 1 month, 3 weeks ago 
On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
>
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>

Could you explain why there are so many SOB here for such a simple
change?

Thanks,

ET

> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f0..cf5698dda91fc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  			precvpriv->rx_drop++;
>  		} else if (retval == _SUCCESS) {
>  #ifdef DBG_RX_DUMP_EAP
> -			u8 bDumpRxPkt;
>  			u16 eth_type;
>  
>  			/*  dump eapol */
Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Posted by 최유호 1 month, 3 weeks ago 
Dear Greg, Andy, Ethan,

Thanks for the feedback.

This patch came from an ongoing research project with my fellow
researchers, and I included
the SOBs to reflect that collaboration. After reviewing the Linux
patch submission conventions
again, I agree that these tags should be limited to people who
directly contributed to the
specific patch itself. For this patch, that attribution was too broad.
I will be more careful about
that in future submissions.

I also understand the concern about the patch itself. I will trace the
logic more carefully.

Best regards,
Yuho Choi



On Mon, 20 Apr 2026 at 18:08, Ethan Tidmore <ethantidmore06@gmail.com> wrote:
>
> On Sun Apr 19, 2026 at 10:05 PM CDT, Yuho Choi wrote:
> > DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> > shadowing the existing function-local variable. Drop the inner declaration
> > and reuse the existing variable to avoid unnecessary shadowing.
> >
> > Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> > Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> > Co-developed-by: Ijae Kim <ae878000@gmail.com>
> > Signed-off-by: Ijae Kim <ae878000@gmail.com>
> > Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> > Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> > Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
>
> Could you explain why there are so many SOB here for such a simple
> change?
>
> Thanks,
>
> ET
>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > index 337671b1211f0..cf5698dda91fc 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> >                       precvpriv->rx_drop++;
> >               } else if (retval == _SUCCESS) {
> >  #ifdef DBG_RX_DUMP_EAP
> > -                     u8 bDumpRxPkt;
> >                       u16 eth_type;
> >
> >                       /*  dump eapol */
>
Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Posted by Greg Kroah-Hartman 1 month, 3 weeks ago 
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
> 
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f0..cf5698dda91fc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  			precvpriv->rx_drop++;
>  		} else if (retval == _SUCCESS) {
>  #ifdef DBG_RX_DUMP_EAP
> -			u8 bDumpRxPkt;

If you trace this back, why is this variable being used at all?  Look at
how it is being used, and please explain the logic here.

Personally, I think this can be deleted entirely, but please verify
this.

thanks,

greg k-h
Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Posted by Andy Shevchenko 1 month, 3 weeks ago 
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.

> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>

You are kidding me...

>  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
>  1 file changed, 1 deletion(-)

^^^^^^^^

-- 
With Best Regards,
Andy Shevchenko

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.