[PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"

Ninad Naik posted 1 patch 2 months ago
Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
Posted by Ninad Naik 2 months ago
There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
Fixing it.

Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
---
 Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst b/Documentation/wmi/devices/lenovo-wmi-other.rst
index 01d471156738..1d0410500d3f 100644
--- a/Documentation/wmi/devices/lenovo-wmi-other.rst
+++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
@@ -144,5 +144,5 @@ data using the `bmfdec <https://github.com/pali/bmfdec>`_ utility:
     [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
     [WmiDataId(2), read, Description("Fan ID."), WmiSizeIs("NumOfFans")] uint32 FanId[];
     [WmiDataId(3), read, Description("Maximum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
-    [WmiDataId(4), read, Description("Minumum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
+    [WmiDataId(4), read, Description("Minimum Fan Speed."), WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
   };
-- 
2.53.0
Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
Posted by Mark Pearson 2 months ago

On Sun, Apr 19, 2026, at 1:08 PM, Ninad Naik wrote:
> There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
> Fixing it.
>
> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
> ---
>  Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst 
> b/Documentation/wmi/devices/lenovo-wmi-other.rst
> index 01d471156738..1d0410500d3f 100644
> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
> @@ -144,5 +144,5 @@ data using the `bmfdec 
> <https://github.com/pali/bmfdec>`_ utility:
>      [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
>      [WmiDataId(2), read, Description("Fan ID."), 
> WmiSizeIs("NumOfFans")] uint32 FanId[];
>      [WmiDataId(3), read, Description("Maximum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
> -    [WmiDataId(4), read, Description("Minumum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
> +    [WmiDataId(4), read, Description("Minimum Fan Speed."), 
> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>    };
> -- 
> 2.53.0
Looks good.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
Posted by Derek J. Clark 2 months ago
On April 19, 2026 3:10:08 PM PDT, Mark Pearson <mpearson-lenovo@squebb.ca> wrote:
>
>
>On Sun, Apr 19, 2026, at 1:08 PM, Ninad Naik wrote:
>> There is a spelling mistake in Documentation/wmi/devices/lenovo-wmi-other.rst.
>> Fixing it.
>>
>> Signed-off-by: Ninad Naik <ninadnaik07@gmail.com>
>> ---
>>  Documentation/wmi/devices/lenovo-wmi-other.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/wmi/devices/lenovo-wmi-other.rst 
>> b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> index 01d471156738..1d0410500d3f 100644
>> --- a/Documentation/wmi/devices/lenovo-wmi-other.rst
>> +++ b/Documentation/wmi/devices/lenovo-wmi-other.rst
>> @@ -144,5 +144,5 @@ data using the `bmfdec 
>> <https://github.com/pali/bmfdec>`_ utility:
>>      [WmiDataId(1), read, Description("Mode.")] uint32 NumOfFans;
>>      [WmiDataId(2), read, Description("Fan ID."), 
>> WmiSizeIs("NumOfFans")] uint32 FanId[];
>>      [WmiDataId(3), read, Description("Maximum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMaxSpeed[];
>> -    [WmiDataId(4), read, Description("Minumum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>> +    [WmiDataId(4), read, Description("Minimum Fan Speed."), 
>> WmiSizeIs("NumOfFans")] uint32 FanMinSpeed[];
>>    };
>> -- 
>> 2.53.0
>Looks good.
>Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Hi gents,

The MOF spelling mistakes are well known. We've left them is as to ensure match with what the hardware actually reports.

See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de

I suppose if we're going to continue getting these types or PR I should add a note to the documentation. I'll add that soon.

Thanks,
Derek
Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
Posted by Jonathan Corbet 2 months ago
"Derek J. Clark" <derekjohn.clark@gmail.com> writes:

> The MOF spelling mistakes are well known. We've left them is as to
> ensure match with what the hardware actually reports.
>
> See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de
>
> I suppose if we're going to continue getting these types or PR I
> should add a note to the documentation. I'll add that soon.

Perhaps worth adding, but I'm not sure I would expect it to help.  The
people generating these patches aren't putting much attention into the
context surrounding them.

Thanks,

jon
Re: [PATCH] Documentation: fix spelling mistake "Minumum" -> "Minimum"
Posted by Mark Pearson 2 months ago
On Mon, Apr 20, 2026, at 2:47 AM, Jonathan Corbet wrote:
> "Derek J. Clark" <derekjohn.clark@gmail.com> writes:
>
>> The MOF spelling mistakes are well known. We've left them is as to
>> ensure match with what the hardware actually reports.
>>
>> See: https://lore.kernel.org/platform-driver-x86/cfd7977e-d612-4e08-a68a-65fed8e164b6@gmx.de
>>
>> I suppose if we're going to continue getting these types or PR I
>> should add a note to the documentation. I'll add that soon.
>
> Perhaps worth adding, but I'm not sure I would expect it to help.  The
> people generating these patches aren't putting much attention into the
> context surrounding them.
>
I'd forgotten that previous discussion - sorry.

Part of the problem (I know I had this many years ago when I got started) is being told the best way to get involved in kernel development and learn the process is to find small things to fix (spelling mistakes, documentation, comments etc). I suspect that's accelerated with AI identifying them too :)

What if we fix the typo, and add a comment highlighting that the vendor documentation/MOF/whatever is wrong? Then everybody is 'happy'? (or at least we'll get less emails about it)

Mark