perf unwind-libdw: Fix stale object reference in arch/loongarch

[PATCH] perf unwind-libdw: Fix stale object reference in arch/loongarch

Posted by Icenowy Zheng 1 month, 4 weeks ago

The arch/loongarch/util/unwind-libdw.c file is already moved to util/,
but the Build statement for it is forgot to be removed.

Remove the stale Build statement.

This fixes the build failure of perf tool in kernel v7.0 on LoongArch.

Fixes: e62fae9d9e85 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: stable@vger.kernel.org
---
 tools/perf/arch/loongarch/util/Build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/arch/loongarch/util/Build b/tools/perf/arch/loongarch/util/Build
index 3ad73d0289f3e..8d91e78d31c94 100644
--- a/tools/perf/arch/loongarch/util/Build
+++ b/tools/perf/arch/loongarch/util/Build
@@ -1,4 +1,3 @@
 perf-util-y += header.o
 
 perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
-perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
-- 
2.52.0

Re: [PATCH] perf unwind-libdw: Fix stale object reference in arch/loongarch

Posted by Ian Rogers 1 month, 3 weeks ago

On Sun, Apr 19, 2026 at 2:08 AM Icenowy Zheng <zhengxingda@iscas.ac.cn> wrote:
>
> The arch/loongarch/util/unwind-libdw.c file is already moved to util/,
> but the Build statement for it is forgot to be removed.
>
> Remove the stale Build statement.
>
> This fixes the build failure of perf tool in kernel v7.0 on LoongArch.
>
> Fixes: e62fae9d9e85 ("perf unwind-libdw: Fix a cross-arch unwinding bug")
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> Cc: stable@vger.kernel.org

I think this is already fixed:
https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=perf-tools-next
I also sent out a fix, fwiw:
https://lore.kernel.org/linux-perf-users/20260305221927.3237145-3-irogers@google.com/

Thanks,
Ian

> ---
>  tools/perf/arch/loongarch/util/Build | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/arch/loongarch/util/Build b/tools/perf/arch/loongarch/util/Build
> index 3ad73d0289f3e..8d91e78d31c94 100644
> --- a/tools/perf/arch/loongarch/util/Build
> +++ b/tools/perf/arch/loongarch/util/Build
> @@ -1,4 +1,3 @@
>  perf-util-y += header.o
>
>  perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
> -perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
> --
> 2.52.0
>

Re: [PATCH] perf unwind-libdw: Fix stale object reference in arch/loongarch

Posted by Icenowy Zheng 1 month, 3 weeks ago

在 2026-04-19日的 08:01 -0700，Ian Rogers写道：
> On Sun, Apr 19, 2026 at 2:08 AM Icenowy Zheng
> <zhengxingda@iscas.ac.cn> wrote:
> > 
> > The arch/loongarch/util/unwind-libdw.c file is already moved to
> > util/,
> > but the Build statement for it is forgot to be removed.
> > 
> > Remove the stale Build statement.
> > 
> > This fixes the build failure of perf tool in kernel v7.0 on
> > LoongArch.
> > 
> > Fixes: e62fae9d9e85 ("perf unwind-libdw: Fix a cross-arch unwinding
> > bug")
> > Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> > Cc: stable@vger.kernel.org
> 
> I think this is already fixed:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=perf-tools-next

Thanks for pointing out!

Thanks,
Icenowy

> I also sent out a fix, fwiw:
> https://lore.kernel.org/linux-perf-users/20260305221927.3237145-3-irogers@google.com/
> 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/arch/loongarch/util/Build | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/tools/perf/arch/loongarch/util/Build
> > b/tools/perf/arch/loongarch/util/Build
> > index 3ad73d0289f3e..8d91e78d31c94 100644
> > --- a/tools/perf/arch/loongarch/util/Build
> > +++ b/tools/perf/arch/loongarch/util/Build
> > @@ -1,4 +1,3 @@
> >  perf-util-y += header.o
> > 
> >  perf-util-$(CONFIG_LOCAL_LIBUNWIND) += unwind-libunwind.o
> > -perf-util-$(CONFIG_LIBDW_DWARF_UNWIND) += unwind-libdw.o
> > --
> > 2.52.0
> >