[PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep

Abhai Kollara posted 1 patch 1 month, 4 weeks ago
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
Posted by Abhai Kollara 1 month, 4 weeks ago
The gc2235 driver uses msleep(5) during power-up. msleep() is often
imprecise for durations under 20ms. Replace it with fsleep()
to provide better precision.

Signed-off-by: Abhai Kollara <abhai@protonmail.com>
---
v3:
 - Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.
v2:
 - Replaced msleep() with usleep_range() (Superseded).
v1:
 - Initial version.

 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index d3414312e1de..7999c8595a68 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd)
 			goto fail_power;
 	}
 
-	msleep(5);
+	fsleep(5000);
 	return 0;
 
 fail_clk:
-- 
2.43.0
Re: [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
Posted by Sakari Ailus 1 month, 4 weeks ago
Hi Abhai,

On Sat, Apr 18, 2026 at 08:18:01PM +0000, Abhai Kollara wrote:
> The gc2235 driver uses msleep(5) during power-up. msleep() is often
> imprecise for durations under 20ms. Replace it with fsleep()
> to provide better precision.
> 
> Signed-off-by: Abhai Kollara <abhai@protonmail.com>
> ---
> v3:
>  - Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.

The commit 968d8904c2f86996b0615a08ee4048bccac56758 apparently already does
this in my atomisp branch.

-- 
Kind regards,

Sakari Ailus