staging: rtl8723bs: os_dep: remove unnecessary braces for single statement

[PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement

Posted by Shyam Sunder Reddy Padira 1 month, 4 weeks ago

Remove redundant braces around single statement blocks to follow
kernel coding style and improve readability.

Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..a86252ccac76 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
 		sdio_claim_host(func);
 		sdio_disable_func(func);
 
-		if (dvobj->irq_alloc) {
+		if (dvobj->irq_alloc)
 			sdio_release_irq(func);
-		}
 
 		sdio_release_host(func);
 	}
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement

Posted by Luka Gejak 1 month, 3 weeks ago

On Sat Apr 18, 2026 at 7:19 PM CEST, Shyam Sunder Reddy Padira wrote:
> Remove redundant braces around single statement blocks to follow
> kernel coding style and improve readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
>  		sdio_claim_host(func);
>  		sdio_disable_func(func);
>  
> -		if (dvobj->irq_alloc) {
> +		if (dvobj->irq_alloc)
>  			sdio_release_irq(func);
> -		}
>  
>  		sdio_release_host(func);
>  	}

LGTM.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement

Posted by Josh Law 1 month, 4 weeks ago

Hello shyam.

Seems good enough to me

Reviewed-by: Josh Law <joshlaw48@gmail.com>

If you like this file, feel free to check the TODO file!

(I'm not the driver maintainer or anything btw! Sorry if this is
disturbing the maintainers or anything)

V/R

Josh Law