1. Patchew
  2. linux
  3. View series

[PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device

Baojun Xu posted 1 patch 1 month, 4 weeks ago 
sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 1 +
sound/soc/codecs/tas2781-fmwlib.c              | 7 +++----
2 files changed, 4 insertions(+), 4 deletions(-)
[PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Posted by Baojun Xu 1 month, 4 weeks ago 
In the SPI driver probe, the chip ID must be set to TAS2781. Without this
initialization, calibration data fails to load correctly, causing audio
abnormalities on some devices.
And update the register bulk read API to handle the distinct requirements
of SPI and I2C devices.

Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
Signed-off-by: Baojun Xu <baojun.xu@ti.com>
---
 sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 1 +
 sound/soc/codecs/tas2781-fmwlib.c              | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
index f860e0eb7602..560f2385212d 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
@@ -788,6 +788,7 @@ static int tas2781_hda_spi_probe(struct spi_device *spi)
 	}
 	if (strstr(dev_name(&spi->dev), "TXNW2781")) {
 		device_name = "TXNW2781";
+		tas_hda->priv->chip_id = TAS2781;
 	} else {
 		dev_err(tas_priv->dev, "Unmatched spi dev %s\n",
 			dev_name(&spi->dev));
diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index a1d86bd309f4..885e0b6fed00 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -2487,7 +2487,7 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
 		if (spec == NULL)
 			return -ENOMEM;
 		priv->tasdevice[i].cali_specific = spec;
-		rc = tasdevice_dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
+		rc = priv->dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
 		if (rc < 0) {
 			dev_err(priv->dev, "invalid RE from %d = %d\n", i, rc);
 			return rc;
@@ -2511,9 +2511,8 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
 				TASDEVICE_REG(0, 0x1b, 0x34) :
 				TASDEVICE_REG(0, 0x18, 0x1c);
 
-			rc = tasdevice_dev_bulk_read(priv, i,
-						      spec->sin_gni_reg,
-						      spec->sin_gni, 4);
+			rc = priv->dev_bulk_read(priv, i, spec->sin_gni_reg,
+						 spec->sin_gni, 4);
 			if (rc < 0) {
 				dev_err(priv->dev, "wrong sinegaini %d = %d\n",
 					i, rc);
-- 
2.25.1
Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Posted by Eric Naim 1 month, 3 weeks ago 
On 4/18/26 1:50 PM, Baojun Xu wrote:
> In the SPI driver probe, the chip ID must be set to TAS2781. Without this
> initialization, calibration data fails to load correctly, causing audio
> abnormalities on some devices.
> And update the register bulk read API to handle the distinct requirements
> of SPI and I2C devices.
> 
> Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
> ---
>  sound/hda/codecs/side-codecs/tas2781_hda_spi.c | 1 +
>  sound/soc/codecs/tas2781-fmwlib.c              | 7 +++----
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
> index f860e0eb7602..560f2385212d 100644
> --- a/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
> +++ b/sound/hda/codecs/side-codecs/tas2781_hda_spi.c
> @@ -788,6 +788,7 @@ static int tas2781_hda_spi_probe(struct spi_device *spi)
>  	}
>  	if (strstr(dev_name(&spi->dev), "TXNW2781")) {
>  		device_name = "TXNW2781";
> +		tas_hda->priv->chip_id = TAS2781;
>  	} else {
>  		dev_err(tas_priv->dev, "Unmatched spi dev %s\n",
>  			dev_name(&spi->dev));
> diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
> index a1d86bd309f4..885e0b6fed00 100644
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -2487,7 +2487,7 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
>  		if (spec == NULL)
>  			return -ENOMEM;
>  		priv->tasdevice[i].cali_specific = spec;
> -		rc = tasdevice_dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
> +		rc = priv->dev_bulk_read(priv, i, p->r0_reg, r0_deflt, 4);
>  		if (rc < 0) {
>  			dev_err(priv->dev, "invalid RE from %d = %d\n", i, rc);
>  			return rc;
> @@ -2511,9 +2511,8 @@ static int tas2781_cali_preproc(struct tasdevice_priv *priv, int i)
>  				TASDEVICE_REG(0, 0x1b, 0x34) :
>  				TASDEVICE_REG(0, 0x18, 0x1c);
>  
> -			rc = tasdevice_dev_bulk_read(priv, i,
> -						      spec->sin_gni_reg,
> -						      spec->sin_gni, 4);
> +			rc = priv->dev_bulk_read(priv, i, spec->sin_gni_reg,
> +						 spec->sin_gni, 4);
>  			if (rc < 0) {
>  				dev_err(priv->dev, "wrong sinegaini %d = %d\n",
>  					i, rc);

Hi Baojun, will this fix
https://lore.kernel.org/linux-sound/20260315160939.191265-1-dnaim@cachyos.org/ ?

Similarly, I noticed that something like the above was merged upstream, commit
0bdf27abaf894.

-- 
Regards,
  Eric
Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Posted by Xu, Baojun 1 month, 3 weeks ago 
Hi Eric,

> 
> ________________________________________
> From: Eric Naim <dnaim@cachyos.org>
> Sent: 20 April 2026 14:43
> To: Xu, Baojun; tiwai@suse.de; hansg@kernel.org
> Cc: ilpo.jarvinen@linux.intel.com; broonie@kernel.org; andriy.shevchenko@linux.intel.com; Ding, Shenghao; 13916275206@139.com; platform-driver-x86@vger.kernel.org; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; letitia.tsai@hp.com; bill.yu@canonical.com
> Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
> 
> On 4/18/26 1:50 PM, Baojun Xu wrote:
> > In the SPI driver probe, the chip ID must be set to TAS2781. Without this
> > initialization, calibration data fails to load correctly, causing audio
> > abnormalities on some devices.
> > And update the register bulk read API to handle the distinct requirements
> > of SPI and I2C devices.
> >
> > Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
>> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
> > ---
> Hi Baojun, will this fix
> https://urldefense.com/v3/__https://lore.kernel.org/linux-sound/20260315160939.191265-1-dnaim@cachyos.org/__;!!G3vK!X-jfopjNDyUV4Zt7eHbLDT79zxX8PrVATeyHGzNtgCNvue6wSwqHWSaaVOuqjRfYbzZ5TQzNVhRq$ ?
> 
> Similarly, I noticed that something like the above was merged upstream, commit
> 0bdf27abaf894.
> 

To clarify: The patch mentioned earlier was designed to register the correct project with the codec.
My patch specifically resolves the issue where calibration data fails to be applied properly.

> --
> Regards,
>   Eric
> 
> 

Best Regards
Jim
Re: [PATCH v1] ALSA: hda/tas2781: Fix sound abnormal issue on some SPI device
Posted by Takashi Iwai 1 month, 3 weeks ago 
On Sat, 18 Apr 2026 07:50:30 +0200,
Baojun Xu wrote:
> 
> In the SPI driver probe, the chip ID must be set to TAS2781. Without this
> initialization, calibration data fails to load correctly, causing audio
> abnormalities on some devices.
> And update the register bulk read API to handle the distinct requirements
> of SPI and I2C devices.
> 
> Fixes: 05ac3846ffe5 ("ALSA: hda/tas2781: A workaround solution to lower-vol issue among lower calibrated-impedance micro-speaker on TAS2781")
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>

Applied now.  Thanks.


Takashi

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.