[PATCH] sched/eevdf: fix update negative lag

Vincent Guittot posted 1 patch 2 months ago
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] sched/eevdf: fix update negative lag
Posted by Vincent Guittot 2 months ago
update_entity_lag() should return true when the se->vlag is changed during
the update.

Fixes: 059258b0d424 ("sched/fair: Prevent negative lag increase during delayed dequeue")

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index f179faf7a6a1..d3d858a9f700 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -863,7 +863,7 @@ bool update_entity_lag(struct cfs_rq *cfs_rq, struct sched_entity *se)
 		if (sched_feat(DELAY_ZERO))
 			vlag = min(vlag, 0);
 	}
-	ret = (vlag == se->vlag);
+	ret = (vlag != se->vlag);
 	se->vlag = vlag;
 
 	return ret;
-- 
2.43.0