[PATCH v2 0/4] mailbox: mailbox-test: fix issues reported by Sashiko

Wolfram Sang posted 4 patches 1 month, 4 weeks ago
drivers/mailbox/mailbox-test.c | 30 ++++++++++++++----------------
1 file changed, 14 insertions(+), 16 deletions(-)
[PATCH v2 0/4] mailbox: mailbox-test: fix issues reported by Sashiko
Posted by Wolfram Sang 1 month, 4 weeks ago
Changes since v1:
* added tag to patch 1 (Thanks, Geert!)
* fixed 'workqueue' typo in commit message to 'waitqueue'
* added patch 4

There were some more comments to my v1 patch series from Sashiko[1] but
I will leave it here. I don't use signals so far, so I'll leave that
part for someone else. And the rest of the comments are somehow valid
but keeping in mind that this is a debug driver only, some compromises
can be made. The patches here are worth fixing, though, IMO.

Tested with a Renesas Ironhide board (R-Car X5H).

[1] https://sashiko.dev/#/patchset/20260416114737.36988-1-wsa%2Brenesas%40sang-engineering.com

Wolfram Sang (4):
  mailbox: mailbox-test: handle channel errors consistently
  mailbox: mailbox-test: don't free the reused channel
  mailbox: mailbox-test: initialize struct earlier
  mailbox: mailbox-test: make data_ready a per-instance variable

 drivers/mailbox/mailbox-test.c | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

-- 
2.51.0
Re: [PATCH v2 0/4] mailbox: mailbox-test: fix issues reported by Sashiko
Posted by Jassi Brar 1 month, 4 weeks ago
On Fri, Apr 17, 2026 at 2:42 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Changes since v1:
> * added tag to patch 1 (Thanks, Geert!)
> * fixed 'workqueue' typo in commit message to 'waitqueue'
> * added patch 4
>
> There were some more comments to my v1 patch series from Sashiko[1] but
> I will leave it here. I don't use signals so far, so I'll leave that
> part for someone else. And the rest of the comments are somehow valid
> but keeping in mind that this is a debug driver only, some compromises
> can be made. The patches here are worth fixing, though, IMO.
>
> Tested with a Renesas Ironhide board (R-Car X5H).
>
> [1] https://sashiko.dev/#/patchset/20260416114737.36988-1-wsa%2Brenesas%40sang-engineering.com
>
> Wolfram Sang (4):
>   mailbox: mailbox-test: handle channel errors consistently
>   mailbox: mailbox-test: don't free the reused channel
>   mailbox: mailbox-test: initialize struct earlier
>   mailbox: mailbox-test: make data_ready a per-instance variable
>
>  drivers/mailbox/mailbox-test.c | 30 ++++++++++++++----------------
>  1 file changed, 14 insertions(+), 16 deletions(-)
>
> --
> 2.51.0
>
Applied to mailbox/for-next
Thanks
Jassi