1. Patchew
  2. linux
  3. View series

[PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property

Ariana Lazar posted 1 patch 1 month, 4 weeks ago 
Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by Ariana Lazar 1 month, 4 weeks ago 
Change maxItems value from 8 to 1 for the channel number reg property.

Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
Link: https://lore.kernel.org/all/20260403-speed-childless-1360de358229@spud/
Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
---
Changes in v2:
- keep just maxItems value update in this patch
- remove Reported-by from commit message
- Link to v1: https://lore.kernel.org/r/20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com
---
 Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
index d2466aa6bda2106a8b695347a0edf38462294d03..f2efa0ccbaa32482dcdc69d98c1565518538793f 100644
--- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
@@ -161,8 +161,7 @@ patternProperties:
     properties:
       reg:
         description: The channel number.
-        minItems: 1
-        maxItems: 8
+        maxItems: 1
 
       label:
         description: Unique name to identify which channel this is.

---
base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
change-id: 20260416-mcp47feb02-fix5-26994c5b428c

Best regards,
-- 
Ariana Lazar <ariana.lazar@microchip.com>
Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by Rob Herring 1 month, 3 weeks ago 
On Fri, Apr 17, 2026 at 04:38:29PM +0300, Ariana Lazar wrote:
> Change maxItems value from 8 to 1 for the channel number reg property.
> 
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> Link: https://lore.kernel.org/all/20260403-speed-childless-1360de358229@spud/
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> ---
> Changes in v2:
> - keep just maxItems value update in this patch
> - remove Reported-by from commit message
> - Link to v1: https://lore.kernel.org/r/20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com
> ---
>  Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> index d2466aa6bda2106a8b695347a0edf38462294d03..f2efa0ccbaa32482dcdc69d98c1565518538793f 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> @@ -161,8 +161,7 @@ patternProperties:
>      properties:
>        reg:
>          description: The channel number.
> -        minItems: 1
> -        maxItems: 8
> +        maxItems: 1

Perhaps there are 8 channels and 'maximum: 8' is what was intended?

Rob
Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by Ariana.Lazar@microchip.com 1 month, 3 weeks ago 
Hello Rob,

> > @@ -161,8 +161,7 @@ patternProperties:
> >      properties:
> >        reg:
> >          description: The channel number.
> > -        minItems: 1
> > -        maxItems: 8
> > +        maxItems: 1
> 
> Perhaps there are 8 channels and 'maximum: 8' is what was intended?



Thank you for the review.

Indeed, I mistakenly set maxItems to the maximum number of channels,
rather than to a single entry for the reg property (reg value is
between 0 and max 7 based on the part number).

If preferred, I can also add minimum: 0 and maximum: 7 to specify the
valid range for the channel number.

Best regards,
Ariana
Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by David Lechner 1 month, 3 weeks ago 
On 4/21/26 9:11 AM, Ariana.Lazar@microchip.com wrote:
> Hello Rob,
> 
>>> @@ -161,8 +161,7 @@ patternProperties:
>>>      properties:
>>>        reg:
>>>          description: The channel number.
>>> -        minItems: 1
>>> -        maxItems: 8
>>> +        maxItems: 1
>>
>> Perhaps there are 8 channels and 'maximum: 8' is what was intended?
> 
> 
> 
> Thank you for the review.
> 
> Indeed, I mistakenly set maxItems to the maximum number of channels,
> rather than to a single entry for the reg property (reg value is
> between 0 and max 7 based on the part number).
> 

> If preferred, I can also add minimum: 0 and maximum: 7 to specify the
> valid range for the channel number.
> 

Yes, that sounds like the right idea.
Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by David Lechner 1 month, 4 weeks ago 
On 4/17/26 8:38 AM, Ariana Lazar wrote:
> Change maxItems value from 8 to 1 for the channel number reg property.

The commit message needs to explain why this is the correct thing to do.

> 
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> Link: https://lore.kernel.org/all/20260403-speed-childless-1360de358229@spud/
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> ---
> Changes in v2:
> - keep just maxItems value update in this patch
> - remove Reported-by from commit message
> - Link to v1: https://lore.kernel.org/r/20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com
> ---
>  Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> index d2466aa6bda2106a8b695347a0edf38462294d03..f2efa0ccbaa32482dcdc69d98c1565518538793f 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> @@ -161,8 +161,7 @@ patternProperties:
>      properties:
>        reg:
>          description: The channel number.
> -        minItems: 1
> -        maxItems: 8
> +        maxItems: 1
>  
>        label:
>          description: Unique name to identify which channel this is.
> 
> ---
> base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
> change-id: 20260416-mcp47feb02-fix5-26994c5b428c
> 
> Best regards,
Re: [PATCH v2] dt-bindings: iio: dac: mcp47feb02: Fix maxItems value for reg property
Posted by Conor Dooley 1 month, 4 weeks ago 
On Fri, Apr 17, 2026 at 10:26:42AM -0500, David Lechner wrote:
> On 4/17/26 8:38 AM, Ariana Lazar wrote:
> > Change maxItems value from 8 to 1 for the channel number reg property.
> 
> The commit message needs to explain why this is the correct thing to do.

With that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: changes-requested

> 
> > 
> > Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> > Link: https://lore.kernel.org/all/20260403-speed-childless-1360de358229@spud/
> > Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> > ---
> > Changes in v2:
> > - keep just maxItems value update in this patch
> > - remove Reported-by from commit message
> > - Link to v1: https://lore.kernel.org/r/20260416-mcp47feb02-fix5-v1-1-9656c2fed6d2@microchip.com
> > ---
> >  Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > index d2466aa6bda2106a8b695347a0edf38462294d03..f2efa0ccbaa32482dcdc69d98c1565518538793f 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> > @@ -161,8 +161,7 @@ patternProperties:
> >      properties:
> >        reg:
> >          description: The channel number.
> > -        minItems: 1
> > -        maxItems: 8
> > +        maxItems: 1
> >  
> >        label:
> >          description: Unique name to identify which channel this is.
> > 
> > ---
> > base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
> > change-id: 20260416-mcp47feb02-fix5-26994c5b428c
> > 
> > Best regards,
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.