Bluetooth: btintel_pcie: Add ACPI dependency

[PATCH] Bluetooth: btintel_pcie: Add ACPI dependency

Posted by Venkat Rao Bagalkote 2 months ago

The btintel_pcie driver uses ACPI functions (acpi_has_method,
ACPI_HANDLE, acpi_evaluate_dsm) in btintel_pcie_acpi_reset_method()
but can be built without CONFIG_ACPI, leading to build failures
discovered by IBM CI:

drivers/bluetooth/btintel_pcie.c:2309:14: error: implicit declaration
of function 'acpi_has_method' [-Werror=implicit-function-declaration]
 2309 |         if (!acpi_has_method(handle, "_PRR")) {
      |              ^~~~~~~~~~~~~~~

Add ACPI dependency to the Kconfig entry to prevent building this
driver when ACPI is disabled, since the driver requires ACPI
functionality for its reset method.

Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Closes: https://lore.kernel.org/all/ad624e0d-cfd7-4521-ae33-c5c3287b4204@linux.ibm.com/
Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
Suggested-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
Hi Marcel and Luiz,

I'm submitting a fix for a build failure in the btintel_pcie driver when
CONFIG_ACPI is not set. Christophe Leroy helped identify that commit
912a499a7955 introduced this issue.

 drivers/bluetooth/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index c5d45cf91f88..fc1b37044a9b 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -502,7 +502,7 @@ config BT_NXPUART
 
 config BT_INTEL_PCIE
 	tristate "Intel HCI PCIe driver"
-	depends on PCI
+	depends on PCI && ACPI
 	select BT_INTEL
 	select FW_LOADER
 	help
-- 
2.45.2

Re: [PATCH] Bluetooth: btintel_pcie: Add ACPI dependency

Posted by Luiz Augusto von Dentz 2 months ago

Hi Venkat,

On Thu, Apr 16, 2026 at 11:28 AM Venkat Rao Bagalkote
<venkat88@linux.ibm.com> wrote:
>
> The btintel_pcie driver uses ACPI functions (acpi_has_method,
> ACPI_HANDLE, acpi_evaluate_dsm) in btintel_pcie_acpi_reset_method()
> but can be built without CONFIG_ACPI, leading to build failures
> discovered by IBM CI:
>
> drivers/bluetooth/btintel_pcie.c:2309:14: error: implicit declaration
> of function 'acpi_has_method' [-Werror=implicit-function-declaration]
>  2309 |         if (!acpi_has_method(handle, "_PRR")) {
>       |              ^~~~~~~~~~~~~~~
>
> Add ACPI dependency to the Kconfig entry to prevent building this
> driver when ACPI is disabled, since the driver requires ACPI
> functionality for its reset method.
>
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Closes: https://lore.kernel.org/all/ad624e0d-cfd7-4521-ae33-c5c3287b4204@linux.ibm.com/
> Fixes: 912a499a7955 ("Bluetooth: btintel_pcie: Support Product level reset")
> Suggested-by: Rafael J. Wysocki <rafael@kernel.org>
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---
> Hi Marcel and Luiz,
>
> I'm submitting a fix for a build failure in the btintel_pcie driver when
> CONFIG_ACPI is not set. Christophe Leroy helped identify that commit
> 912a499a7955 introduced this issue.
>
>  drivers/bluetooth/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index c5d45cf91f88..fc1b37044a9b 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -502,7 +502,7 @@ config BT_NXPUART
>
>  config BT_INTEL_PCIE
>         tristate "Intel HCI PCIe driver"
> -       depends on PCI
> +       depends on PCI && ACPI

Good catch, I will fix it in place.

>         select BT_INTEL
>         select FW_LOADER
>         help
> --
> 2.45.2
>


-- 
Luiz Augusto von Dentz