[PATCH] mm/vmscan: fix typos in comments

Xiang Gao posted 1 patch 2 months ago
There is a newer version of this series
mm/vmscan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] mm/vmscan: fix typos in comments
Posted by Xiang Gao 2 months ago
From: Xiang Gao <gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
 	/* zone_reclaim_mode */
 	unsigned int may_unmap:1;
 
-	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
 	unsigned int may_swap:1;
 
 	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
 	if (current_is_kswapd() || cgroup_reclaim(sc))
 		return;
 
-	/* Throttle if making no progress at high prioities. */
+	/* Throttle if making no progress at high priorities. */
 	if (sc->priority == 1 && !sc->nr_reclaimed)
 		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
 
 		/*
 		 * There should be no need to raise the scanning priority if
-		 * enough pages are already being scanned that that high
+		 * enough pages are already being scanned that the high
 		 * watermark would be met at 100% efficiency.
 		 */
 		if (kswapd_shrink_node(pgdat, &sc))
-- 
2.34.1
Re: [PATCH] mm/vmscan: fix typos in comments
Posted by Barry Song 2 months ago
On Thu, Apr 16, 2026 at 10:43 AM Xiang Gao <gxxa03070307@gmail.com> wrote:
>
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>

Should be:
Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>

Otherwise,

Reviewed-by: Barry Song <baohua@kernel.org>
Re: [PATCH] mm/vmscan: fix typos in comments
Posted by Donet Tom 2 months ago
Hi

On 4/16/26 8:12 AM, Xiang Gao wrote:
> From: Xiang Gao <gaoxiang17@xiaomi.com>
>
> Fix three typos in comments:
>
> - Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
> - Line 6208: "prioities" -> "priorities"
> - Line 7067: "that that high" -> "that the high" (duplicated word)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>


I am seeing below issue with checkpatch.pl

./scripts/checkpatch.pl --strict 0001-mm-vmscan-fix-typos-in-comments.patch
WARNING: From:/Signed-off-by: email name mismatch: 'From: Xiang Gao 
<gaoxiang17@xiaomi.com>' != 'Signed-off-by: gaoxiang17 
<gaoxiang17@xiaomi.com>'

total: 0 errors, 1 warnings, 0 checks, 24 lines checked

> ---
>   mm/vmscan.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 0fc9373e8251..710fbe1ee151 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -109,7 +109,7 @@ struct scan_control {
>   	/* zone_reclaim_mode */
>   	unsigned int may_unmap:1;
>   
> -	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
> +	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
>   	unsigned int may_swap:1;
>   
>   	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
> @@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
>   	if (current_is_kswapd() || cgroup_reclaim(sc))
>   		return;
>   
> -	/* Throttle if making no progress at high prioities. */
> +	/* Throttle if making no progress at high priorities. */
>   	if (sc->priority == 1 && !sc->nr_reclaimed)
>   		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
>   }
> @@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
>   
>   		/*
>   		 * There should be no need to raise the scanning priority if
> -		 * enough pages are already being scanned that that high
> +		 * enough pages are already being scanned that the high
>   		 * watermark would be met at 100% efficiency.
>   		 */
>   		if (kswapd_shrink_node(pgdat, &sc))
[PATCH v2] mm/vmscan: fix typos in comments
Posted by Xiang Gao 2 months ago
From: Xiang Gao <gaoxiang17@xiaomi.com>

Fix three typos in comments:

- Line 112: "zome_reclaim_mode" -> "zone_reclaim_mode"
- Line 6208: "prioities" -> "priorities"
- Line 7067: "that that high" -> "that the high" (duplicated word)

Signed-off-by: Xiang Gao <gaoxiang17@xiaomi.com>
Reviewed-by: Barry Song <baohua@kernel.org>
---
 mm/vmscan.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0fc9373e8251..710fbe1ee151 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -109,7 +109,7 @@ struct scan_control {
 	/* zone_reclaim_mode */
 	unsigned int may_unmap:1;
 
-	/* zome_reclaim_mode, boost reclaim, cgroup restrictions */
+	/* zone_reclaim_mode, boost reclaim, cgroup restrictions */
 	unsigned int may_swap:1;
 
 	/* Not allow cache_trim_mode to be turned on as part of reclaim? */
@@ -6205,7 +6205,7 @@ static void consider_reclaim_throttle(pg_data_t *pgdat, struct scan_control *sc)
 	if (current_is_kswapd() || cgroup_reclaim(sc))
 		return;
 
-	/* Throttle if making no progress at high prioities. */
+	/* Throttle if making no progress at high priorities. */
 	if (sc->priority == 1 && !sc->nr_reclaimed)
 		reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS);
 }
@@ -7064,7 +7064,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)
 
 		/*
 		 * There should be no need to raise the scanning priority if
-		 * enough pages are already being scanned that that high
+		 * enough pages are already being scanned that the high
 		 * watermark would be met at 100% efficiency.
 		 */
 		if (kswapd_shrink_node(pgdat, &sc))
-- 
2.34.1