wifi: ath12k: Remove macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS

[PATCH ath-next] wifi: ath12k: Remove macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS

Posted by Jeff Johnson 2 months ago

Macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS unused, so remove it.

No functional change, compile Tested only.

Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
This issue was highlighted by AI review which noted that the
HAL_RX_EHT_SIG_OFDMA_EB2_MCS macro misspelled GENMASK_ULL().
However, rather than fix an unused macro, it seems "better" to just
remove it.
---
 drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
index ac2a8ac03288..dd60626b3240 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
@@ -559,7 +559,6 @@ struct hal_eht_sig_ofdma_cmn_eb1 {
 #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_4		GENMASK_ULL(35, 27)
 #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_5		GENMASK_ULL(44, 36)
 #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_6		GENMASK_ULL(53, 45)
-#define HAL_RX_EHT_SIG_OFDMA_EB2_MCS			GNEMASK_ULL(57, 54)
 
 struct hal_eht_sig_ofdma_cmn_eb2 {
 	__le64 info0;

---
base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c
change-id: 20260405-hal_rx_eht_sig_ofdma_eb2_mcs-a22a27f955bb

Re: [PATCH ath-next] wifi: ath12k: Remove macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS

Posted by Jeff Johnson 1 month, 3 weeks ago

On Thu, 16 Apr 2026 13:02:46 -0700, Jeff Johnson wrote:
> Macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS unused, so remove it.
> 
> No functional change, compile Tested only.
> 
> 

Applied, thanks!

[1/1] wifi: ath12k: Remove macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS
      commit: 5c2ab62af09f7394a538739a1b130f0c88ad15f1

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>

Re: [PATCH ath-next] wifi: ath12k: Remove macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS

Posted by Baochen Qiang 2 months ago


On 4/17/2026 4:02 AM, Jeff Johnson wrote:
> Macro HAL_RX_EHT_SIG_OFDMA_EB2_MCS unused, so remove it.
> 
> No functional change, compile Tested only.
> 
> Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
> ---
> This issue was highlighted by AI review which noted that the
> HAL_RX_EHT_SIG_OFDMA_EB2_MCS macro misspelled GENMASK_ULL().
> However, rather than fix an unused macro, it seems "better" to just
> remove it.
> ---
>  drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
> index ac2a8ac03288..dd60626b3240 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h
> @@ -559,7 +559,6 @@ struct hal_eht_sig_ofdma_cmn_eb1 {
>  #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_4		GENMASK_ULL(35, 27)
>  #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_5		GENMASK_ULL(44, 36)
>  #define HAL_RX_EHT_SIG_OFDMA_EB2_RU_ALLOC_2_6		GENMASK_ULL(53, 45)
> -#define HAL_RX_EHT_SIG_OFDMA_EB2_MCS			GNEMASK_ULL(57, 54)
>  
>  struct hal_eht_sig_ofdma_cmn_eb2 {
>  	__le64 info0;
> 
> ---
> base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c
> change-id: 20260405-hal_rx_eht_sig_ofdma_eb2_mcs-a22a27f955bb

Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>

> 
>