Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
From: Vishwas Rajashekar <vishwas.dev@vrajashkr.com>
Adds mount-matrix as an optional property to dt-bindings
for the bmg160 gyroscope as the driver reads this optional
property during probe.
Signed-off-by: Vishwas Rajashekar <vishwas.dev@vrajashkr.com>
---
The bmg160 driver reads an optional mount-matrix using
"iio_read_mount_matrix" in "bmg160_core_probe" and stores
this orientation data in "struct bmg160_data". As the "mount-matrix"
property is used by the driver, this change proposes to add it to
the corresponding dt-bindings.
---
Changes in v2:
- Addressed review feedback: add mount-matrix example for bmg160
- Link to v1: https://patch.msgid.link/20260415-bmg160-mount-matrix-dt-binding-v1-1-0e2c85964ee6@vrajashkr.com
To: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
To: Nuno Sá <nuno.sa@analog.com>
To: Andy Shevchenko <andy@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: linux-iio@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
index 3c6fe74af0b8..ec97778cca78 100644
--- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
+++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
@@ -22,6 +22,9 @@ properties:
vdd-supply: true
vddio-supply: true
+ mount-matrix:
+ description: an optional 3x3 mounting rotation matrix.
+
spi-max-frequency:
maximum: 10000000
@@ -52,6 +55,9 @@ examples:
reg = <0x69>;
interrupt-parent = <&gpio6>;
interrupts = <18 IRQ_TYPE_EDGE_RISING>;
+ mount-matrix = "0", "1", "0",
+ "1", "0", "0",
+ "0", "0", "1";
};
};
...
---
base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2
change-id: 20260414-bmg160-mount-matrix-dt-binding-e76ddde94866
Best regards,
--
Vishwas Rajashekar <vishwas.dev@vrajashkr.com>
On Thu, Apr 16, 2026 at 08:33:21PM +0530, Vishwas Rajashekar via B4 Relay wrote: > From: Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > > Adds mount-matrix as an optional property to dt-bindings > for the bmg160 gyroscope as the driver reads this optional > property during probe. Ultimately, what the driver does is not relevant here. All that matters is that the property is relevant to the hardware. Please come up with a commit message that avoids mentioning linux drivers and instead explains why it is relevant to the hardware. pw-bot: changes-requested Cheers, Conor. > > Signed-off-by: Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > --- > The bmg160 driver reads an optional mount-matrix using > "iio_read_mount_matrix" in "bmg160_core_probe" and stores > this orientation data in "struct bmg160_data". As the "mount-matrix" > property is used by the driver, this change proposes to add it to > the corresponding dt-bindings. > --- > Changes in v2: > - Addressed review feedback: add mount-matrix example for bmg160 > - Link to v1: https://patch.msgid.link/20260415-bmg160-mount-matrix-dt-binding-v1-1-0e2c85964ee6@vrajashkr.com > > To: Jonathan Cameron <jic23@kernel.org> > To: David Lechner <dlechner@baylibre.com> > To: Nuno Sá <nuno.sa@analog.com> > To: Andy Shevchenko <andy@kernel.org> > To: Rob Herring <robh@kernel.org> > To: Krzysztof Kozlowski <krzk+dt@kernel.org> > To: Conor Dooley <conor+dt@kernel.org> > To: "H. Nikolaus Schaller" <hns@goldelico.com> > Cc: linux-iio@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > index 3c6fe74af0b8..ec97778cca78 100644 > --- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > +++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > @@ -22,6 +22,9 @@ properties: > vdd-supply: true > vddio-supply: true > > + mount-matrix: > + description: an optional 3x3 mounting rotation matrix. > + > spi-max-frequency: > maximum: 10000000 > > @@ -52,6 +55,9 @@ examples: > reg = <0x69>; > interrupt-parent = <&gpio6>; > interrupts = <18 IRQ_TYPE_EDGE_RISING>; > + mount-matrix = "0", "1", "0", > + "1", "0", "0", > + "0", "0", "1"; > }; > }; > ... > > --- > base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2 > change-id: 20260414-bmg160-mount-matrix-dt-binding-e76ddde94866 > > Best regards, > -- > Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > >
On Thursday, April 16th, 2026 at 21:12, Conor Dooley <conor@kernel.org> wrote: > On Thu, Apr 16, 2026 at 08:33:21PM +0530, Vishwas Rajashekar via B4 Relay wrote: > > From: Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > > > > Adds mount-matrix as an optional property to dt-bindings > > for the bmg160 gyroscope as the driver reads this optional > > property during probe. > > Ultimately, what the driver does is not relevant here. All that matters > is that the property is relevant to the hardware. Please come up with a > commit message that avoids mentioning linux drivers and instead explains > why it is relevant to the hardware. > > pw-bot: changes-requested > > Cheers, > Conor. > Thank you for the feedback! I've updated the commit message in v3. > > > > Signed-off-by: Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > > --- > > The bmg160 driver reads an optional mount-matrix using > > "iio_read_mount_matrix" in "bmg160_core_probe" and stores > > this orientation data in "struct bmg160_data". As the "mount-matrix" > > property is used by the driver, this change proposes to add it to > > the corresponding dt-bindings. > > --- > > Changes in v2: > > - Addressed review feedback: add mount-matrix example for bmg160 > > - Link to v1: https://patch.msgid.link/20260415-bmg160-mount-matrix-dt-binding-v1-1-0e2c85964ee6@vrajashkr.com > > > > To: Jonathan Cameron <jic23@kernel.org> > > To: David Lechner <dlechner@baylibre.com> > > To: Nuno Sá <nuno.sa@analog.com> > > To: Andy Shevchenko <andy@kernel.org> > > To: Rob Herring <robh@kernel.org> > > To: Krzysztof Kozlowski <krzk+dt@kernel.org> > > To: Conor Dooley <conor+dt@kernel.org> > > To: "H. Nikolaus Schaller" <hns@goldelico.com> > > Cc: linux-iio@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > > index 3c6fe74af0b8..ec97778cca78 100644 > > --- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > > +++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml > > @@ -22,6 +22,9 @@ properties: > > vdd-supply: true > > vddio-supply: true > > > > + mount-matrix: > > + description: an optional 3x3 mounting rotation matrix. > > + > > spi-max-frequency: > > maximum: 10000000 > > > > @@ -52,6 +55,9 @@ examples: > > reg = <0x69>; > > interrupt-parent = <&gpio6>; > > interrupts = <18 IRQ_TYPE_EDGE_RISING>; > > + mount-matrix = "0", "1", "0", > > + "1", "0", "0", > > + "0", "0", "1"; > > }; > > }; > > ... > > > > --- > > base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2 > > change-id: 20260414-bmg160-mount-matrix-dt-binding-e76ddde94866 > > > > Best regards, > > -- > > Vishwas Rajashekar <vishwas.dev@vrajashkr.com> > > > > > Regards, Vishwas
© 2016 - 2026 Red Hat, Inc.