[PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()

deep@crimson.net.eu.org posted 1 patch 2 months ago
There is a newer version of this series
drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
Posted by deep@crimson.net.eu.org 2 months ago
From: Kenet Jovan Sokoli <deep@crimson.net.eu.org>

Signed-off-by: Kenet Jovan Sokoli <deep@crimson.net.eu.org>
---
 drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index aa90b27197cf..9b5b640e53b3 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		mutex_lock(&fifo->write_lock);
 
 		ret = wait_event_interruptible(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
+			words_to_write);
 		if (ret)
 			goto end_unlock;
 	}
-- 
2.43.0
Re: [PATCH] staging: axis-fifo: fix alignment in wait_event_interruptible()
Posted by Dan Carpenter 2 months ago
On Mon, Apr 13, 2026 at 04:05:08PM +0200, deep@crimson.net.eu.org wrote:
> From: Kenet Jovan Sokoli <deep@crimson.net.eu.org>
> 
> Signed-off-by: Kenet Jovan Sokoli <deep@crimson.net.eu.org>

No commit message.

> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aa90b27197cf..9b5b640e53b3 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> +			words_to_write);

The code was better before.  Just leave it as-is.

regards,
dan carpenter

>  		if (ret)
>  			goto end_unlock;
>  	}