drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

[PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

Posted by Arnd Bergmann 2 months ago

From: Arnd Bergmann <arnd@arndb.de>

Like a number of other panel drivers, this newly merged driver
needs DRM_DISPLAY_DSC_HELPER to be enabled:

arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'

Fixes: a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index cc8c8a066bb9..ce6098c0343a 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
 	select DRM_KMS_HELPER
 	help
 	  Say Y here if you want to enable support for Himax HX83121A-based
-- 
2.39.5

Re: [PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

Posted by Neil Armstrong 1 month, 1 week ago

Hi,

On Mon, 13 Apr 2026 09:10:19 +0200, Arnd Bergmann wrote:
> Like a number of other panel drivers, this newly merged driver
> needs DRM_DISPLAY_DSC_HELPER to be enabled:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
> panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'
> 
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/defab7b01e0848e004077d7d8dcc04d305ea1a27

-- 
Neil

Re: [PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

Posted by David Heidelberg 2 months ago

On 13/04/2026 09:10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Like a number of other panel drivers, this newly merged driver
> needs DRM_DISPLAY_DSC_HELPER to be enabled:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
> panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'
> 
> Fixes: a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cc8c8a066bb9..ce6098c0343a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
>   	select DRM_KMS_HELPER
>   	help
>   	  Say Y here if you want to enable support for Himax HX83121A-based

Reviewed-by: David Heidelberg <david@ixit.cz>

Re: [PATCH] drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER

Posted by Neil Armstrong 2 months ago

On 4/13/26 09:10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Like a number of other panel drivers, this newly merged driver
> needs DRM_DISPLAY_DSC_HELPER to be enabled:
> 
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-himax-hx83121a.o: in function `himax_prepare':
> panel-himax-hx83121a.c:(.text+0x1024): undefined reference to `drm_dsc_pps_payload_pack'
> 
> Fixes: a7c61963b727 ("drm/panel: Add Himax HX83121A panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index cc8c8a066bb9..ce6098c0343a 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -208,6 +208,7 @@ config DRM_PANEL_HIMAX_HX83121A
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
>   	select DRM_KMS_HELPER
>   	help
>   	  Say Y here if you want to enable support for Himax HX83121A-based

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil