[PATCH v2] hwmon: (nct6683) Add customer ID for ASRock B650I Lightning WiFi

pklotz0@protonmail.com posted 1 patch 2 months ago
There is a newer version of this series
drivers/hwmon/nct6683.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH v2] hwmon: (nct6683) Add customer ID for ASRock B650I Lightning WiFi
Posted by pklotz0@protonmail.com 2 months ago
From: Petr Klotz <pklotz0@protonmail.com>

This value was found on ASRock B650I Lightning WiFi with NCT6686D chip.
Signed-off-by: Petr Klotz <pklotz0@protonmail.com>
---
 drivers/hwmon/nct6683.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 4a8380414038..0581770380cc 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -182,6 +182,7 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
 #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
 #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
+#define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
 
 #define NCT6683_REG_BUILD_YEAR		0x604
 #define NCT6683_REG_BUILD_MONTH		0x605
@@ -1245,6 +1246,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK5:
 		break;
+	case NCT6683_CUSTOMER_ID_ASROCK6:
+		break;
 	default:
 		if (!force)
 			return -ENODEV;
-- 
2.53.0
Re: [PATCH v2] hwmon: (nct6683) Add customer ID for ASRock B650I Lightning WiFi
Posted by Guenter Roeck 2 months ago
On 4/11/26 13:40, pklotz0@protonmail.com wrote:
> From: Petr Klotz <pklotz0@protonmail.com>
> 
> This value was found on ASRock B650I Lightning WiFi with NCT6686D chip.

This is not an appropriate patch description.

AI prompt: "Convert the patch description to a format matching the requirements in
Documentation/process/submitting-patches.rst"

and it gives me:

hwmon: (nct6683) Add a new customer ID for ASRock B650I Lightning WiFi

The ASRock B650I Lightning WiFi motherboard uses an NCT6686D chip with a
customer ID of 0x1633. Without this ID, the nct6683 driver fails to
recognize the hardware on this board, preventing hardware monitoring
from working.

Add NCT6683_CUSTOMER_ID_ASROCK6 (0x1633) to the list of supported customer
IDs and update the probe function to handle it.

> Signed-off-by: Petr Klotz <pklotz0@protonmail.com>
> ---

Change log goes here, not in a separate e-mail.

Guenter

>   drivers/hwmon/nct6683.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 4a8380414038..0581770380cc 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -182,6 +182,7 @@ superio_exit(int ioreg)
>   #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
>   #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
>   #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
> +#define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
>   
>   #define NCT6683_REG_BUILD_YEAR		0x604
>   #define NCT6683_REG_BUILD_MONTH		0x605
> @@ -1245,6 +1246,8 @@ static int nct6683_probe(struct platform_device *pdev)
>   		break;
>   	case NCT6683_CUSTOMER_ID_ASROCK5:
>   		break;
> +	case NCT6683_CUSTOMER_ID_ASROCK6:
> +		break;
>   	default:
>   		if (!force)
>   			return -ENODEV;
Re: [PATCH v2] hwmon: (nct6683) Add customer ID for ASRock B650I Lightning WiFi
Posted by pklotz0 2 months ago
V2 fixes embarassing whitespace issue




sobota, 11 kwietnia 2026 21:40, pklotz0@protonmail.com <pklotz0@protonmail.com> napisał(a):

> From: Petr Klotz <pklotz0@protonmail.com>
>
> This value was found on ASRock B650I Lightning WiFi with NCT6686D chip.
> Signed-off-by: Petr Klotz <pklotz0@protonmail.com>
> ---
>  drivers/hwmon/nct6683.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 4a8380414038..0581770380cc 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -182,6 +182,7 @@ superio_exit(int ioreg)
>  #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
>  #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
>  #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
> +#define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
>
>  #define NCT6683_REG_BUILD_YEAR		0x604
>  #define NCT6683_REG_BUILD_MONTH		0x605
> @@ -1245,6 +1246,8 @@ static int nct6683_probe(struct platform_device *pdev)
>  		break;
>  	case NCT6683_CUSTOMER_ID_ASROCK5:
>  		break;
> +	case NCT6683_CUSTOMER_ID_ASROCK6:
> +		break;
>  	default:
>  		if (!force)
>  			return -ENODEV;
> --
> 2.53.0
>
>