hfsplus: remove xattr error message

[PATCH] hfsplus: remove xattr error message

Posted by Colin Ian King 2 months ago

When exercising hfsplus with the stress-ng xattr stressor a large
quantity of somewhat unhelpful error messages "hfsplus: xattr exists
yet" spam the kernel log. Remove these.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/hfsplus/xattr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
index c70bb6f494b2..e10e1d8a5862 100644
--- a/fs/hfsplus/xattr.c
+++ b/fs/hfsplus/xattr.c
@@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (!strcmp_xattr_finder_info(name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
@@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
 
 	if (hfsplus_attr_exists(inode, name)) {
 		if (flags & XATTR_CREATE) {
-			pr_err("xattr exists yet\n");
 			err = -EOPNOTSUPP;
 			goto end_setxattr;
 		}
-- 
2.53.0

Re: [PATCH] hfsplus: remove xattr error message

Posted by Viacheslav Dubeyko 2 months ago

On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
> When exercising hfsplus with the stress-ng xattr stressor a large
> quantity of somewhat unhelpful error messages "hfsplus: xattr exists
> yet" spam the kernel log. Remove these.

We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
think?

Also, there are other pr_err() in xattr code that can be converted into
hfs_dbg(). Could you please take a look into other ones too?

Thanks,
Slava.

> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  fs/hfsplus/xattr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> index c70bb6f494b2..e10e1d8a5862 100644
> --- a/fs/hfsplus/xattr.c
> +++ b/fs/hfsplus/xattr.c
> @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>  
>  	if (!strcmp_xattr_finder_info(name)) {
>  		if (flags & XATTR_CREATE) {
> -			pr_err("xattr exists yet\n");
>  			err = -EOPNOTSUPP;
>  			goto end_setxattr;
>  		}
> @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>  
>  	if (hfsplus_attr_exists(inode, name)) {
>  		if (flags & XATTR_CREATE) {
> -			pr_err("xattr exists yet\n");
>  			err = -EOPNOTSUPP;
>  			goto end_setxattr;
>  		}

Re: [PATCH] hfsplus: remove xattr error message

Posted by Colin King (gmail) 2 months ago

On 13/04/2026 18:12, Viacheslav Dubeyko wrote:
> On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
>> When exercising hfsplus with the stress-ng xattr stressor a large
>> quantity of somewhat unhelpful error messages "hfsplus: xattr exists
>> yet" spam the kernel log. Remove these.
> 
> We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
> think?

Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be 
rephrased as the message is not really that clear. Any ideas for an 
improved message?

Colin

> 
> Also, there are other pr_err() in xattr code that can be converted into
> hfs_dbg(). Could you please take a look into other ones too?
> 
> Thanks,
> Slava.
> 
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>>   fs/hfsplus/xattr.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
>> index c70bb6f494b2..e10e1d8a5862 100644
>> --- a/fs/hfsplus/xattr.c
>> +++ b/fs/hfsplus/xattr.c
>> @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>>   
>>   	if (!strcmp_xattr_finder_info(name)) {
>>   		if (flags & XATTR_CREATE) {
>> -			pr_err("xattr exists yet\n");
>>   			err = -EOPNOTSUPP;
>>   			goto end_setxattr;
>>   		}
>> @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
>>   
>>   	if (hfsplus_attr_exists(inode, name)) {
>>   		if (flags & XATTR_CREATE) {
>> -			pr_err("xattr exists yet\n");
>>   			err = -EOPNOTSUPP;
>>   			goto end_setxattr;
>>   		}
>

Re: [PATCH] hfsplus: remove xattr error message

Posted by Viacheslav Dubeyko 2 months ago

On Tue, 2026-04-14 at 21:19 +0100, Colin King (gmail) wrote:
> On 13/04/2026 18:12, Viacheslav Dubeyko wrote:
> > On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote:
> > > When exercising hfsplus with the stress-ng xattr stressor a large
> > > quantity of somewhat unhelpful error messages "hfsplus: xattr exists
> > > yet" spam the kernel log. Remove these.
> > 
> > We can convert it into hfs_dbg() and to add showing inode ID + name. What do you
> > think?
> 
> Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be 
> rephrased as the message is not really that clear. Any ideas for an 
> improved message?

Maybe, "unable to recreate the existing xattr"?

Thanks,
Slava.

> 
> Colin
> 
> > 
> > Also, there are other pr_err() in xattr code that can be converted into
> > hfs_dbg(). Could you please take a look into other ones too?
> > 
> > Thanks,
> > Slava.
> > 
> > > 
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > ---
> > >   fs/hfsplus/xattr.c | 2 --
> > >   1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c
> > > index c70bb6f494b2..e10e1d8a5862 100644
> > > --- a/fs/hfsplus/xattr.c
> > > +++ b/fs/hfsplus/xattr.c
> > > @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
> > >   
> > >   	if (!strcmp_xattr_finder_info(name)) {
> > >   		if (flags & XATTR_CREATE) {
> > > -			pr_err("xattr exists yet\n");
> > >   			err = -EOPNOTSUPP;
> > >   			goto end_setxattr;
> > >   		}
> > > @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
> > >   
> > >   	if (hfsplus_attr_exists(inode, name)) {
> > >   		if (flags & XATTR_CREATE) {
> > > -			pr_err("xattr exists yet\n");
> > >   			err = -EOPNOTSUPP;
> > >   			goto end_setxattr;
> > >   		}
> >