test_access_variable_array relied on accessing struct sched_domain::span
to validate variable-length array handling via BTF. Recent scheduler
refactoring removed or hid this field, causing the test
to fail to build.

Given that this test depends on internal scheduler structures that are
subject to refactoring, and equivalent variable-length array coverage
already exists via bpf_testmod-based tests, remove
test_access_variable_array entirely.

Link: https://lore.kernel.org/all/177434340048.1647592.8586759362906719839.tip-bot2@tip-bot2/

Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
---
 .../bpf/prog_tests/access_variable_array.c    | 16 ----------------
 .../bpf/progs/test_access_variable_array.c    | 19 -------------------
 2 files changed, 35 deletions(-)
 delete mode 100644 tools/testing/selftests/bpf/prog_tests/access_variable_array.c
 delete mode 100644 tools/testing/selftests/bpf/progs/test_access_variable_array.c

diff --git a/tools/testing/selftests/bpf/prog_tests/access_variable_array.c b/tools/testing/selftests/bpf/prog_tests/access_variable_array.c
deleted file mode 100644
index 08131782437c..000000000000
--- a/tools/testing/selftests/bpf/prog_tests/access_variable_array.c
+++ /dev/null
@@ -1,16 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Copyright (c) 2022 Bytedance */
-
-#include <test_progs.h>
-#include "test_access_variable_array.skel.h"
-
-void test_access_variable_array(void)
-{
-	struct test_access_variable_array *skel;
-
-	skel = test_access_variable_array__open_and_load();
-	if (!ASSERT_OK_PTR(skel, "test_access_variable_array__open_and_load"))
-		return;
-
-	test_access_variable_array__destroy(skel);
-}
diff --git a/tools/testing/selftests/bpf/progs/test_access_variable_array.c b/tools/testing/selftests/bpf/progs/test_access_variable_array.c
deleted file mode 100644
index 326b7d1f496a..000000000000
--- a/tools/testing/selftests/bpf/progs/test_access_variable_array.c
+++ /dev/null
@@ -1,19 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Copyright (c) 2023 Bytedance */
-
-#include "vmlinux.h"
-#include <bpf/bpf_helpers.h>
-#include <bpf/bpf_tracing.h>
-
-unsigned long span = 0;
-
-SEC("fentry/sched_balance_rq")
-int BPF_PROG(fentry_fentry, int this_cpu, struct rq *this_rq,
-		struct sched_domain *sd)
-{
-	span = sd->span[0];
-
-	return 0;
-}
-
-char _license[] SEC("license") = "GPL";
-- 
2.45.2

On 10/04/26 4:24 pm, Venkat Rao Bagalkote wrote:
> test_access_variable_array relied on accessing struct sched_domain::span
> to validate variable-length array handling via BTF. Recent scheduler
> refactoring removed or hid this field, causing the test
> to fail to build.
>
> Given that this test depends on internal scheduler structures that are
> subject to refactoring, and equivalent variable-length array coverage
> already exists via bpf_testmod-based tests, remove
> test_access_variable_array entirely.
>
> Link: https://lore.kernel.org/all/177434340048.1647592.8586759362906719839.tip-bot2@tip-bot2/
>
> Signed-off-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> ---

Hi,

Tested this patch and it is fixing the build issue.


Without this patch:

progs/test_access_variable_array.c:14:13: error:
no member named 'span' in 'struct sched_domain'
     span = sd->span[0];
                ^~~~

With this patch above build is fixed

Please add below tag

Tested-by: Naveen Kumar Thummalapenta <naveen66@linux.ibm.com>

Regards,
Naveen Kumar T

>   .../bpf/prog_tests/access_variable_array.c    | 16 ----------------
>   .../bpf/progs/test_access_variable_array.c    | 19 -------------------
>   2 files changed, 35 deletions(-)
>   delete mode 100644 tools/testing/selftests/bpf/prog_tests/access_variable_array.c
>   delete mode 100644 tools/testing/selftests/bpf/progs/test_access_variable_array.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/access_variable_array.c b/tools/testing/selftests/bpf/prog_tests/access_variable_array.c
> deleted file mode 100644
> index 08131782437c..000000000000
> --- a/tools/testing/selftests/bpf/prog_tests/access_variable_array.c
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/* Copyright (c) 2022 Bytedance */
> -
> -#include <test_progs.h>
> -#include "test_access_variable_array.skel.h"
> -
> -void test_access_variable_array(void)
> -{
> -	struct test_access_variable_array *skel;
> -
> -	skel = test_access_variable_array__open_and_load();
> -	if (!ASSERT_OK_PTR(skel, "test_access_variable_array__open_and_load"))
> -		return;
> -
> -	test_access_variable_array__destroy(skel);
> -}
> diff --git a/tools/testing/selftests/bpf/progs/test_access_variable_array.c b/tools/testing/selftests/bpf/progs/test_access_variable_array.c
> deleted file mode 100644
> index 326b7d1f496a..000000000000
> --- a/tools/testing/selftests/bpf/progs/test_access_variable_array.c
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/* Copyright (c) 2023 Bytedance */
> -
> -#include "vmlinux.h"
> -#include <bpf/bpf_helpers.h>
> -#include <bpf/bpf_tracing.h>
> -
> -unsigned long span = 0;
> -
> -SEC("fentry/sched_balance_rq")
> -int BPF_PROG(fentry_fentry, int this_cpu, struct rq *this_rq,
> -		struct sched_domain *sd)
> -{
> -	span = sd->span[0];
> -
> -	return 0;
> -}
> -
> -char _license[] SEC("license") = "GPL";