xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING

[PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING

Posted by alexjlzheng@gmail.com 2 months ago

From: Jinliang Zheng <alexjlzheng@tencent.com>

In xfs_refcount_finish_one(), there's no need to pass
XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().

So remove it.

Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
---
 fs/xfs/libxfs/xfs_refcount.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
index 40c7f0ff6cf3..0ec6ccd8b4dc 100644
--- a/fs/xfs/libxfs/xfs_refcount.c
+++ b/fs/xfs/libxfs/xfs_refcount.c
@@ -1414,8 +1414,7 @@ xfs_refcount_finish_one(
 	if (rcur == NULL) {
 		struct xfs_perag	*pag = to_perag(ri->ri_group);
 
-		error = xfs_alloc_read_agf(pag, tp,
-				XFS_ALLOC_FLAG_FREEING, &agbp);
+		error = xfs_alloc_read_agf(pag, tp, 0, &agbp);
 		if (error)
 			return error;
 
-- 
2.49.0

Re: [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING

Posted by Carlos Maiolino 1 month, 2 weeks ago

On Fri, 10 Apr 2026 18:11:06 +0800, alexjlzheng@gmail.com wrote:
> In xfs_refcount_finish_one(), there's no need to pass
> XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().
> 
> So remove it.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING
      commit: bfb4dc533d0abaca07013dd71e6b5c6f182232b3

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>

Re: [PATCH] xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING

Posted by Darrick J. Wong 2 months ago

On Fri, Apr 10, 2026 at 06:11:06PM +0800, alexjlzheng@gmail.com wrote:
> From: Jinliang Zheng <alexjlzheng@tencent.com>
> 
> In xfs_refcount_finish_one(), there's no need to pass
> XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().
> 
> So remove it.
> 
> Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>

Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_refcount.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c
> index 40c7f0ff6cf3..0ec6ccd8b4dc 100644
> --- a/fs/xfs/libxfs/xfs_refcount.c
> +++ b/fs/xfs/libxfs/xfs_refcount.c
> @@ -1414,8 +1414,7 @@ xfs_refcount_finish_one(
>  	if (rcur == NULL) {
>  		struct xfs_perag	*pag = to_perag(ri->ri_group);
>  
> -		error = xfs_alloc_read_agf(pag, tp,
> -				XFS_ALLOC_FLAG_FREEING, &agbp);
> +		error = xfs_alloc_read_agf(pag, tp, 0, &agbp);
>  		if (error)
>  			return error;
>  
> -- 
> 2.49.0
>