[PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7

Oliver White posted 1 patch 2 months, 1 week ago
drivers/platform/surface/surface_aggregator_registry.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
Posted by Oliver White 2 months, 1 week ago
Surface Laptop 7 exposes battery and AC status via Qualcomm PMIC GLINK
qcom_battmgr. Registering the standard SSAM battery and AC client
devices on this platform causes duplicate power-supply devices to
appear.

Drop the SSAM battery and AC nodes from the Surface Laptop 7 registry
group so that only the qcom_battmgr power supplies are instantiated.

Fixes: b27622f13172 ("platform/surface: Add OF support")
Signed-off-by: Oliver White <oliverjwhite07@gmail.com>
---
 drivers/platform/surface/surface_aggregator_registry.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
index 0599d5adf02e..f0881edfb616 100644
--- a/drivers/platform/surface/surface_aggregator_registry.c
+++ b/drivers/platform/surface/surface_aggregator_registry.c
@@ -295,8 +295,6 @@ static const struct software_node *ssam_node_group_sl6[] = {
 /* Devices for Surface Laptop 7. */
 static const struct software_node *ssam_node_group_sl7[] = {
 	&ssam_node_root,
-	&ssam_node_bat_ac,
-	&ssam_node_bat_main,
 	&ssam_node_tmp_perf_profile_with_fan,
 	&ssam_node_fan_speed,
 	&ssam_node_hid_sam_keyboard,
-- 
2.51.0
Re: [PATCH] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
Posted by Ilpo Järvinen 3 weeks, 5 days ago
On Thu, 09 Apr 2026 15:43:47 +1200, Oliver White wrote:

> Surface Laptop 7 exposes battery and AC status via Qualcomm PMIC GLINK
> qcom_battmgr. Registering the standard SSAM battery and AC client
> devices on this platform causes duplicate power-supply devices to
> appear.
> 
> Drop the SSAM battery and AC nodes from the Surface Laptop 7 registry
> group so that only the qcom_battmgr power supplies are instantiated.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/surface: aggregator_registry: omit battery & AC nodes on Surface Laptop 7
      commit: 0488073a6c84571dd3cffe581a4a73a5fceb099d

--
 i.