[PATCH] HID: drop 'default !EXPERT' from HID_PICOLCD symbols

Thomas Weißschuh posted 1 patch 2 months ago
drivers/hid/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
[PATCH] HID: drop 'default !EXPERT' from HID_PICOLCD symbols
Posted by Thomas Weißschuh 2 months ago
The 'EXPERT' configuration is meant to make advanced kconfig options
configurable. It is not meant to actively change these options.
In the case of the HID_PICOLCD suboptions the intention seems to be that
normal users always expect these options to be enabled for the driver.

So 'EXPERT' is enabled, these options should stay enabled and not
automatically and suddenly become disabled. Switch them to 'default y'
to match the intention of a normal user. EXPERT users then can disable
them if needed.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 drivers/hid/Kconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index c1d9f7c6a5f2..1ef4fe3debf2 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -938,7 +938,7 @@ config HID_PICOLCD
 
 config HID_PICOLCD_FB
 	bool "Framebuffer support" if EXPERT
-	default !EXPERT
+	default y
 	depends on HID_PICOLCD
 	depends on HID_PICOLCD=FB || FB=y
 	select FB_SYSMEM_HELPERS_DEFERRED
@@ -948,7 +948,7 @@ config HID_PICOLCD_FB
 
 config HID_PICOLCD_BACKLIGHT
 	bool "Backlight control" if EXPERT
-	default !EXPERT
+	default y
 	depends on HID_PICOLCD
 	depends on HID_PICOLCD=BACKLIGHT_CLASS_DEVICE || BACKLIGHT_CLASS_DEVICE=y
 	help
@@ -957,7 +957,7 @@ config HID_PICOLCD_BACKLIGHT
 
 config HID_PICOLCD_LCD
 	bool "Contrast control" if EXPERT
-	default !EXPERT
+	default y
 	depends on HID_PICOLCD
 	depends on HID_PICOLCD=LCD_CLASS_DEVICE || LCD_CLASS_DEVICE=y
 	help
@@ -965,7 +965,7 @@ config HID_PICOLCD_LCD
 
 config HID_PICOLCD_LEDS
 	bool "GPO via leds class" if EXPERT
-	default !EXPERT
+	default y
 	depends on HID_PICOLCD
 	depends on HID_PICOLCD=LEDS_CLASS || LEDS_CLASS=y
 	help
@@ -973,7 +973,7 @@ config HID_PICOLCD_LEDS
 
 config HID_PICOLCD_CIR
 	bool "CIR via RC class" if EXPERT
-	default !EXPERT
+	default y
 	depends on HID_PICOLCD
 	depends on HID_PICOLCD=RC_CORE || RC_CORE=y
 	help

---
base-commit: 7f87a5ea75f011d2c9bc8ac0167e5e2d1adb1594
change-id: 20260409-hid-picolcd-1b6d7eac5795

Best regards,
--  
Thomas Weißschuh <linux@weissschuh.net>