[PATCH] clocksource: Clean up clocksource_update_freq() functions

Thomas Weißschuh posted 1 patch 2 months, 1 week ago
There is a newer version of this series
include/linux/clocksource.h | 12 ------------
kernel/time/clocksource.c   |  9 +--------
2 files changed, 1 insertion(+), 20 deletions(-)
[PATCH] clocksource: Clean up clocksource_update_freq() functions
Posted by Thomas Weißschuh 2 months, 1 week ago
Remove the unused functions __clocksource_update_freq_hz() and
__clocksource_update_freq_khz().

Then make __clocksource_update_freq_scale() static as it is not used
from external callers anymore. Also clean up the comment accordingly.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 include/linux/clocksource.h | 12 ------------
 kernel/time/clocksource.c   |  9 +--------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index ccf5c0ca26b7..1afe841d268f 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -240,8 +240,6 @@ clocks_calc_mult_shift(u32 *mult, u32 *shift, u32 from, u32 to, u32 minsec);
  */
 extern int
 __clocksource_register_scale(struct clocksource *cs, u32 scale, u32 freq);
-extern void
-__clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq);
 
 /*
  * Don't call this unless you are a default clocksource
@@ -262,16 +260,6 @@ static inline int clocksource_register_khz(struct clocksource *cs, u32 khz)
 	return __clocksource_register_scale(cs, 1000, khz);
 }
 
-static inline void __clocksource_update_freq_hz(struct clocksource *cs, u32 hz)
-{
-	__clocksource_update_freq_scale(cs, 1, hz);
-}
-
-static inline void __clocksource_update_freq_khz(struct clocksource *cs, u32 khz)
-{
-	__clocksource_update_freq_scale(cs, 1000, khz);
-}
-
 #ifdef CONFIG_ARCH_CLOCKSOURCE_INIT
 extern void clocksource_arch_init(struct clocksource *cs);
 #else
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index baee13a1f87f..f8d15ed3ec98 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -1222,14 +1222,8 @@ static void clocksource_enqueue(struct clocksource *cs)
  * @cs:		clocksource to be registered
  * @scale:	Scale factor multiplied against freq to get clocksource hz
  * @freq:	clocksource frequency (cycles per second) divided by scale
- *
- * This should only be called from the clocksource->enable() method.
- *
- * This *SHOULD NOT* be called directly! Please use the
- * __clocksource_update_freq_hz() or __clocksource_update_freq_khz() helper
- * functions.
  */
-void __clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq)
+static void __clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq)
 {
 	u64 sec;
 
@@ -1287,7 +1281,6 @@ void __clocksource_update_freq_scale(struct clocksource *cs, u32 scale, u32 freq
 	pr_info("%s: mask: 0x%llx max_cycles: 0x%llx, max_idle_ns: %lld ns\n",
 		cs->name, cs->mask, cs->max_cycles, cs->max_idle_ns);
 }
-EXPORT_SYMBOL_GPL(__clocksource_update_freq_scale);
 
 /**
  * __clocksource_register_scale - Used to install new clocksources

---
base-commit: 9734946b6c4065628972b6eb2cc79a6d7ce8fce4
change-id: 20260409-clocksource-update_freq-574ec75b9078

Best regards,
--  
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH] clocksource: Clean up clocksource_update_freq() functions
Posted by John Stultz 2 months, 1 week ago
On Thu, Apr 9, 2026 at 5:52 AM Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> Remove the unused functions __clocksource_update_freq_hz() and
> __clocksource_update_freq_khz().
>
> Then make __clocksource_update_freq_scale() static as it is not used
> from external callers anymore. Also clean up the comment accordingly.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Acked-by: John Stultz <jstultz@google.com>