Fix some bugs in the CCP driver

[PATCH v1 0/4] Fix some bugs in the CCP driver

Posted by Tycho Andersen 2 months, 1 week ago

From: "Tycho Andersen (AMD)" <tycho@kernel.org>

This set of fixes came out of using various AI tools on the SNP shutdown
series:
https://lore.kernel.org/all/20260326161110.1764303-1-tycho@kernel.org/

I'm not quite sure how to cite these tools yet, checkpatch complained a
bit about my citations here. Happy to respin if there's a better way. It
looks like e.g. Assisted-by in the process of being added:
https://lore.kernel.org/all/20260302143659.41882-1-thomas.hellstrom@linux.intel.com/

Thanks,

Tycho

Tycho Andersen (AMD) (4):
  crypto/ccp: Reverse the cleanup order in psp_dev_destroy()
  crypto/ccp: Fix snp_filter_reserved_mem_regions() off-by-one
  crypto/ccp: Check for page allocation failure correctly in TIO
  crypto/ccp: Initialize data during __sev_snp_init_locked()

 drivers/crypto/ccp/psp-dev.c |  8 ++++----
 drivers/crypto/ccp/sev-dev.c | 23 +++++++++++++----------
 2 files changed, 17 insertions(+), 14 deletions(-)


base-commit: 6c927e5ca9d238f8ae40b453a8382eb9cf4ee855
-- 
2.53.0

Re: [PATCH v1 0/4] Fix some bugs in the CCP driver

Posted by Herbert Xu 1 month, 1 week ago

On Wed, Apr 08, 2026 at 08:32:55AM -0600, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
> 
> This set of fixes came out of using various AI tools on the SNP shutdown
> series:
> https://lore.kernel.org/all/20260326161110.1764303-1-tycho@kernel.org/
> 
> I'm not quite sure how to cite these tools yet, checkpatch complained a
> bit about my citations here. Happy to respin if there's a better way. It
> looks like e.g. Assisted-by in the process of being added:
> https://lore.kernel.org/all/20260302143659.41882-1-thomas.hellstrom@linux.intel.com/
> 
> Thanks,
> 
> Tycho
> 
> Tycho Andersen (AMD) (4):
>   crypto/ccp: Reverse the cleanup order in psp_dev_destroy()
>   crypto/ccp: Fix snp_filter_reserved_mem_regions() off-by-one
>   crypto/ccp: Check for page allocation failure correctly in TIO
>   crypto/ccp: Initialize data during __sev_snp_init_locked()
> 
>  drivers/crypto/ccp/psp-dev.c |  8 ++++----
>  drivers/crypto/ccp/sev-dev.c | 23 +++++++++++++----------
>  2 files changed, 17 insertions(+), 14 deletions(-)
> 
> 
> base-commit: 6c927e5ca9d238f8ae40b453a8382eb9cf4ee855
> -- 
> 2.53.0

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 0/4] Fix some bugs in the CCP driver

Posted by Tom Lendacky 1 month, 1 week ago

On 4/8/26 09:32, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@kernel.org>
> 
> This set of fixes came out of using various AI tools on the SNP shutdown
> series:
> https://lore.kernel.org/all/20260326161110.1764303-1-tycho@kernel.org/
> 
> I'm not quite sure how to cite these tools yet, checkpatch complained a
> bit about my citations here. Happy to respin if there's a better way. It
> looks like e.g. Assisted-by in the process of being added:
> https://lore.kernel.org/all/20260302143659.41882-1-thomas.hellstrom@linux.intel.com/
> 
> Thanks,
> 
> Tycho
> 
> Tycho Andersen (AMD) (4):
>   crypto/ccp: Reverse the cleanup order in psp_dev_destroy()
>   crypto/ccp: Fix snp_filter_reserved_mem_regions() off-by-one
>   crypto/ccp: Check for page allocation failure correctly in TIO
>   crypto/ccp: Initialize data during __sev_snp_init_locked()
> 
>  drivers/crypto/ccp/psp-dev.c |  8 ++++----
>  drivers/crypto/ccp/sev-dev.c | 23 +++++++++++++----------
>  2 files changed, 17 insertions(+), 14 deletions(-)

For the series:

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
> 
> base-commit: 6c927e5ca9d238f8ae40b453a8382eb9cf4ee855