[PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno

Hungyu Lin posted 6 patches 2 months, 1 week ago
drivers/staging/rtl8723bs/core/rtw_xmit.c     | 138 +++++++++---------
drivers/staging/rtl8723bs/include/rtw_xmit.h  |   1 -
.../staging/rtl8723bs/include/xmit_osdep.h    |   1 -
drivers/staging/rtl8723bs/os_dep/os_intfs.c   |   5 +-
drivers/staging/rtl8723bs/os_dep/xmit_linux.c |  13 --
5 files changed, 74 insertions(+), 84 deletions(-)
[PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno
Posted by Hungyu Lin 2 months, 1 week ago
Convert the xmit initialization path to use standard kernel
return conventions: 0 on success and negative errno on failure.

This replaces the use of _SUCCESS/_FAIL with proper error
codes and improves error propagation.

The changes are split into smaller patches following review
feedback from Dan Carpenter, converting one function at a time
to make the series easier to review.

v5:
- Fix trailing whitespace in os_intfs.c

v4:
- Split into a series of smaller patches as suggested by Dan Carpenter
- Convert functions step by step to improve reviewability
- Ensure each patch builds independently

v3:
- Rebase onto latest staging-next to resolve conflicts.

v2:
- Rework xmit init path to remove _SUCCESS/_FAIL usage
- Convert allocation helpers to return standard error codes
- Update caller to use direct failure checks
- Address review feedback from Ethan Tidmore

Hungyu Lin (6):
  staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow
  staging: rtl8723bs: make rtw_alloc_hwxmits static
  staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno
  staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c
  staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno
  staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno

 drivers/staging/rtl8723bs/core/rtw_xmit.c     | 138 +++++++++---------
 drivers/staging/rtl8723bs/include/rtw_xmit.h  |   1 -
 .../staging/rtl8723bs/include/xmit_osdep.h    |   1 -
 drivers/staging/rtl8723bs/os_dep/os_intfs.c   |   5 +-
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c |  13 --
 5 files changed, 74 insertions(+), 84 deletions(-)

-- 
2.34.1
Re: [PATCH v5 0/6] staging: rtl8723bs: convert xmit init path to errno
Posted by Dan Carpenter 2 months, 1 week ago
On Wed, Apr 08, 2026 at 11:13:08AM +0000, Hungyu Lin wrote:
> Convert the xmit initialization path to use standard kernel
> return conventions: 0 on success and negative errno on failure.
> 
> This replaces the use of _SUCCESS/_FAIL with proper error
> codes and improves error propagation.
> 
> The changes are split into smaller patches following review
> feedback from Dan Carpenter, converting one function at a time
> to make the series easier to review.
> 
> v5:
> - Fix trailing whitespace in os_intfs.c
> 
> v4:
> - Split into a series of smaller patches as suggested by Dan Carpenter
> - Convert functions step by step to improve reviewability
> - Ensure each patch builds independently
>

Thanks!

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter