[v1] staging: rtl8723bs: coding style cleanups for rtl8723b_phycfg.c

[PATCH 0/3] staging: rtl8723bs: coding style cleanups for rtl8723b_phycfg.c

Posted by osjin83@gmail.com 2 months, 1 week ago

From: tas0dev <osjin83@gmail.com>

This patch series fixes various coding style issues in rtl8723b_phycfg.c
as reported by checkpatch.pl

The changes include:
- Fixing spacing around binary and bitwise operators.
- Formatting type casts and aligning function parameters.
- Removing unnecessary blank lines to improve code readability.

These are purely cosmetic changes to bring the driver closer to the
Linux kernel coding style.

I wanted to contribute to Linux, but in the end, I could only make a small change. I'm sorry.

tas0dev (3):
  staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c
  staging: rtl8723bs: fix casting and alignment spacing in
    rtl8723b_phycfg.c
  staging: rtl8723bs: remove unnecessary blank lines in
    rtl8723b_phycfg.c

 .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   | 65 ++++++++-----------
 1 file changed, 26 insertions(+), 39 deletions(-)

-- 
2.53.0

Re: [PATCH 0/3] staging: rtl8723bs: coding style cleanups for rtl8723b_phycfg.c

Posted by Luka Gejak 2 months, 1 week ago

On Wed Apr 8, 2026 at 12:32 PM CEST, osjin83 wrote:
> From: tas0dev <osjin83@gmail.com>
>
> This patch series fixes various coding style issues in rtl8723b_phycfg.c
> as reported by checkpatch.pl
>

...

Also one more thing, when submiting patches make sure that all messages 
are wraped at 70-72 characters.
Best regards,
Luka Gejak

Re: [PATCH 0/3] staging: rtl8723bs: coding style cleanups for rtl8723b_phycfg.c

Posted by Luka Gejak 2 months, 1 week ago

On Wed Apr 8, 2026 at 12:32 PM CEST, osjin83 wrote:
> From: tas0dev <osjin83@gmail.com>
>
> This patch series fixes various coding style issues in rtl8723b_phycfg.c
> as reported by checkpatch.pl
>
> The changes include:
> - Fixing spacing around binary and bitwise operators.
> - Formatting type casts and aligning function parameters.
> - Removing unnecessary blank lines to improve code readability.
>
> These are purely cosmetic changes to bring the driver closer to the
> Linux kernel coding style.
>
> I wanted to contribute to Linux, but in the end, I could only make a small change. I'm sorry.

All contributions are welcome :)
My reviews will be sent shortly.

>
> tas0dev (3):
>   staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c
>   staging: rtl8723bs: fix casting and alignment spacing in
>     rtl8723b_phycfg.c
>   staging: rtl8723bs: remove unnecessary blank lines in
>     rtl8723b_phycfg.c
>
>  .../staging/rtl8723bs/hal/rtl8723b_phycfg.c   | 65 ++++++++-----------
>  1 file changed, 26 insertions(+), 39 deletions(-)