[PATCH v2] ALSA: usb-audio: qcom: Fix incorrect type in enable_audio_stream

songxiebing posted 1 patch 2 months, 1 week ago
sound/usb/qcom/qc_audio_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] ALSA: usb-audio: qcom: Fix incorrect type in enable_audio_stream
Posted by songxiebing 2 months, 1 week ago
Fix sparse warning:
sound/usb/qcom/qc_audio_offload.c:943:27: sparse: incorrect type in argument 2
expected unsigned int val but got snd_pcm_format_t.

Explicitly cast pcm_format to unsigned int for snd_mask_leave().

Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604062109.Oxi8JjWW-lkp@intel.com/
Signed-off-by: songxiebing <songxiebing@kylinos.cn>
---
v2:
 - Add __force prefix for cast
---
 sound/usb/qcom/qc_audio_offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/qcom/qc_audio_offload.c b/sound/usb/qcom/qc_audio_offload.c
index f161eb29f911..9c0d370860f3 100644
--- a/sound/usb/qcom/qc_audio_offload.c
+++ b/sound/usb/qcom/qc_audio_offload.c
@@ -947,7 +947,7 @@ static int enable_audio_stream(struct snd_usb_substream *subs,
 	_snd_pcm_hw_params_any(&params);
 
 	m = hw_param_mask(&params, SNDRV_PCM_HW_PARAM_FORMAT);
-	snd_mask_leave(m, pcm_format);
+	snd_mask_leave(m, (__force unsigned int)pcm_format);
 
 	i = hw_param_interval(&params, SNDRV_PCM_HW_PARAM_CHANNELS);
 	snd_interval_setinteger(i);
-- 
2.25.1
Re: [PATCH v2] ALSA: usb-audio: qcom: Fix incorrect type in enable_audio_stream
Posted by Takashi Iwai 2 months, 1 week ago
On Wed, 08 Apr 2026 10:33:11 +0200,
songxiebing wrote:
> 
> Fix sparse warning:
> sound/usb/qcom/qc_audio_offload.c:943:27: sparse: incorrect type in argument 2
> expected unsigned int val but got snd_pcm_format_t.
> 
> Explicitly cast pcm_format to unsigned int for snd_mask_leave().
> 
> Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604062109.Oxi8JjWW-lkp@intel.com/
> Signed-off-by: songxiebing <songxiebing@kylinos.cn>
> ---
> v2:
>  - Add __force prefix for cast

Applied to for-next branch.  Thanks.


Takashi