[PATCH v2 0/7] regulator: fix OF node imbalance on reuse

Johan Hovold posted 7 patches 2 months, 1 week ago
drivers/regulator/act8945a-regulator.c  | 3 ++-
drivers/regulator/bd9571mwv-regulator.c | 3 ++-
drivers/regulator/bq257xx-regulator.c   | 3 +--
drivers/regulator/max77650-regulator.c  | 2 +-
drivers/regulator/mt6357-regulator.c    | 2 +-
drivers/regulator/rk808-regulator.c     | 3 +--
drivers/regulator/s2dos05-regulator.c   | 2 +-
7 files changed, 9 insertions(+), 9 deletions(-)
[PATCH v2 0/7] regulator: fix OF node imbalance on reuse
Posted by Johan Hovold 2 months, 1 week ago
These drivers reuse the OF node of their parent multi-function device
but fail to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.
	        
Fix this by using the intended helper for reusing OF nodes.

Note that the first two patches will cause a trivial conflict with Doug's
series adding accessor functions for struct device flags which has now been
merged to the driver-core tree:

	https://lore.kernel.org/r/20260406232444.3117516-1-dianders@chromium.org

Johan


Changes in v2:
 - use the correct rk808 Fixes tag
 - merge all the fixes into one series


Johan Hovold (7):
  regulator: bq257xx: fix OF node reference imbalance
  regulator: rk808: fix OF node reference imbalance
  regulator: max77650: fix OF node reference imbalance
  regulator: mt6357: fix OF node reference imbalance
  regulator: s2dos05: fix OF node reference imbalance
  regulator: act8945a: fix OF node reference imbalance
  regulator: bd9571mwv: fix OF node reference imbalance

 drivers/regulator/act8945a-regulator.c  | 3 ++-
 drivers/regulator/bd9571mwv-regulator.c | 3 ++-
 drivers/regulator/bq257xx-regulator.c   | 3 +--
 drivers/regulator/max77650-regulator.c  | 2 +-
 drivers/regulator/mt6357-regulator.c    | 2 +-
 drivers/regulator/rk808-regulator.c     | 3 +--
 drivers/regulator/s2dos05-regulator.c   | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.52.0
Re: [PATCH v2 0/7] regulator: fix OF node imbalance on reuse
Posted by Mark Brown 2 months ago
On Wed, 08 Apr 2026 09:30:48 +0200, Johan Hovold wrote:
> regulator: fix OF node imbalance on reuse
> 
> These drivers reuse the OF node of their parent multi-function device
> but fail to take another reference to balance the one dropped by the
> platform bus code when unbinding the MFD and deregistering the child
> devices.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.1

Thanks!

[1/7] regulator: bq257xx: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/7ea07bc030d8
[2/7] regulator: rk808: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/65290b24d8a5
[3/7] regulator: max77650: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/2edaf5f7ada0
[4/7] regulator: mt6357: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/2f38e96c273e
[5/7] regulator: s2dos05: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/ebe694d67f15
[6/7] regulator: act8945a: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/0d15ce31375c
[7/7] regulator: bd9571mwv: fix OF node reference imbalance
      https://git.kernel.org/broonie/regulator/c/8498100ee1d0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH v2 0/7] regulator: fix OF node imbalance on reuse
Posted by Mark Brown 2 months, 1 week ago
On Wed, Apr 08, 2026 at 09:30:48AM +0200, Johan Hovold wrote:

> Changes in v2:
>  - use the correct rk808 Fixes tag
>  - merge all the fixes into one series

Please don't do stuff like this, it just makes it more annoying to track
what's going on, especially given that you have other similar patches
not included in this in flight, you sent some of these less than 24
hours ago and the ones this replaces aren't named consistently
("reference" vs "imbalance").  Either leave things a bit longer or stick
with the serieses you have.
Re: [PATCH v2 0/7] regulator: fix OF node imbalance on reuse
Posted by Johan Hovold 2 months ago
On Wed, Apr 08, 2026 at 05:56:49PM +0100, Mark Brown wrote:
> On Wed, Apr 08, 2026 at 09:30:48AM +0200, Johan Hovold wrote:
> 
> > Changes in v2:
> >  - use the correct rk808 Fixes tag
> >  - merge all the fixes into one series
> 
> Please don't do stuff like this, it just makes it more annoying to track
> what's going on, especially given that you have other similar patches
> not included in this in flight, you sent some of these less than 24
> hours ago and the ones this replaces aren't named consistently
> ("reference" vs "imbalance").  Either leave things a bit longer or stick
> with the serieses you have.

Sorry, was just trying to make it easier for you since I know you use
feature branches when merging series (and these should all have been in
one series from the start).

The patches themselves have identical summaries, even if the series
names vary a bit.

Here are the three series this one supersedes:

	https://lore.kernel.org/lkml/20260407094156.2573027-1-johan@kernel.org/
	https://lore.kernel.org/lkml/20260407122031.2669397-1-johan@kernel.org/
	https://lore.kernel.org/lkml/20260407124836.2689436-1-johan@kernel.org/

Johan