drm/exynos/fimd: fix register offset type in fimd_trigger()

[PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

Posted by Chen-Yu Tsai 2 months, 1 week ago

Sparse reports:

    exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
    exynos_drm_fimd.c:992:39:    expected void *timing_base
    exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
    exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
    exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
    exynos_drm_fimd.c:1005:33:    got void *
    exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
    exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
    exynos_drm_fimd.c:1007:33:    got void *

Add "__iomem" to *timing_base to fix its type.

Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
random warning I found while checking for the size_t warning.
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index b6abdc4f2b0a..695d3515d421 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
 {
 	struct fimd_context *ctx = dev_get_drvdata(dev);
 	const struct fimd_driver_data *driver_data = ctx->driver_data;
-	void *timing_base = ctx->regs + driver_data->timing_base;
+	void __iomem *timing_base = ctx->regs + driver_data->timing_base;
 	u32 reg;
 
 	 /*
-- 
2.53.0.1213.gd9a14994de-goog

Re: [PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

Posted by Marek Szyprowski 1 month, 1 week ago

On 08.04.2026 08:50, Chen-Yu Tsai wrote:
> Sparse reports:
>
>     exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
>     exynos_drm_fimd.c:992:39:    expected void *timing_base
>     exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
>     exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
>     exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
>     exynos_drm_fimd.c:1005:33:    got void *
>     exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
>     exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
>     exynos_drm_fimd.c:1007:33:    got void *
>
> Add "__iomem" to *timing_base to fix its type.
>
> Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>


> ---
> random warning I found while checking for the size_t warning.
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index b6abdc4f2b0a..695d3515d421 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
>  {
>  	struct fimd_context *ctx = dev_get_drvdata(dev);
>  	const struct fimd_driver_data *driver_data = ctx->driver_data;
> -	void *timing_base = ctx->regs + driver_data->timing_base;
> +	void __iomem *timing_base = ctx->regs + driver_data->timing_base;
>  	u32 reg;
>  
>  	 /*

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Re: [PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

Posted by Chen-Yu Tsai 1 week, 6 days ago

On Wed, May 6, 2026 at 2:35 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> On 08.04.2026 08:50, Chen-Yu Tsai wrote:
> > Sparse reports:
> >
> >     exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
> >     exynos_drm_fimd.c:992:39:    expected void *timing_base
> >     exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
> >     exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
> >     exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
> >     exynos_drm_fimd.c:1005:33:    got void *
> >     exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
> >     exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
> >     exynos_drm_fimd.c:1007:33:    got void *
> >
> > Add "__iomem" to *timing_base to fix its type.
> >
> > Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

Inki, you missed this patch as well.


ChenYu

> > ---
> > random warning I found while checking for the size_t warning.
> > ---
> >  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > index b6abdc4f2b0a..695d3515d421 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > @@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
> >  {
> >       struct fimd_context *ctx = dev_get_drvdata(dev);
> >       const struct fimd_driver_data *driver_data = ctx->driver_data;
> > -     void *timing_base = ctx->regs + driver_data->timing_base;
> > +     void __iomem *timing_base = ctx->regs + driver_data->timing_base;
> >       u32 reg;
> >
> >        /*
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>

Re: [PATCH] drm/exynos/fimd: fix register offset type in fimd_trigger()

Posted by Inki Dae 1 week, 6 days ago

2026년 6월 1일 (월) 오후 1:44, Chen-Yu Tsai <wenst@chromium.org>님이 작성:
>
> On Wed, May 6, 2026 at 2:35 PM Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
> >
> > On 08.04.2026 08:50, Chen-Yu Tsai wrote:
> > > Sparse reports:
> > >
> > >     exynos_drm_fimd.c:992:39: warning: incorrect type in initializer (different address spaces)
> > >     exynos_drm_fimd.c:992:39:    expected void *timing_base
> > >     exynos_drm_fimd.c:992:39:    got void [noderef] __iomem *
> > >     exynos_drm_fimd.c:1005:33: warning: incorrect type in argument 1 (different address spaces)
> > >     exynos_drm_fimd.c:1005:33:    expected void const volatile [noderef] __iomem *addr
> > >     exynos_drm_fimd.c:1005:33:    got void *
> > >     exynos_drm_fimd.c:1007:33: warning: incorrect type in argument 2 (different address spaces)
> > >     exynos_drm_fimd.c:1007:33:    expected void volatile [noderef] __iomem *addr
> > >     exynos_drm_fimd.c:1007:33:    got void *
> > >
> > > Add "__iomem" to *timing_base to fix its type.
> > >
> > > Fixes: 3854fab24e89 ("drm/exynos: fimd: support LCD I80 interface")
> > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> >
> > Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> Inki, you missed this patch as well.

Thanks for letting me know. I will pick it up.

Thanks,
Inki Dae

>
>
> ChenYu
>
> > > ---
> > > random warning I found while checking for the size_t warning.
> > > ---
> > >  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > > index b6abdc4f2b0a..695d3515d421 100644
> > > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> > > @@ -989,7 +989,7 @@ static void fimd_trigger(struct device *dev)
> > >  {
> > >       struct fimd_context *ctx = dev_get_drvdata(dev);
> > >       const struct fimd_driver_data *driver_data = ctx->driver_data;
> > > -     void *timing_base = ctx->regs + driver_data->timing_base;
> > > +     void __iomem *timing_base = ctx->regs + driver_data->timing_base;
> > >       u32 reg;
> > >
> > >        /*
> >
> > Best regards
> > --
> > Marek Szyprowski, PhD
> > Samsung R&D Institute Poland
> >
>