[v1] ARM: dts: exynos: Add bluetooth support to manta

[PATCH] ARM: dts: exynos: Add bluetooth support to manta

Posted by Lukas Timmermann 2 months, 1 week ago

Enable the bcm4330-bt device for manta boards on serial0.
Also adds the necessary pin definitions and interrupt handling for
wakeup.

Signed-off-by: Lukas Timmermann <linux@timmermann.space>
Co-developed-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
---
This patch depends on previous patches which are
currently only found in linux-next.
See: https://lore.kernel.org/all/177214038655.341086.4114348823043257597.b4-ty@kernel.org/
---
 arch/arm/boot/dts/samsung/exynos5250-manta.dts | 41 +++++++++++++++++++++++++-
 1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
index 24a27b342227..76d3657eb22f 100644
--- a/arch/arm/boot/dts/samsung/exynos5250-manta.dts
+++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
@@ -461,6 +461,13 @@ acc_int: acc-int-pins {
 		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
 	};
 
+	bt_host_wakeup: bt-host-wakeup-pins {
+		samsung,pins = "gpx2-6";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+	};
+
 	max77686_irq: max77686-irq-pins {
 		samsung,pins = "gpx0-2";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
@@ -488,6 +495,20 @@ bh1721fvc_reset: bh1721fvc-reset-pins {
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 	};
 
+	bt_reg_on: bt-reg-on-pins {
+		samsung,pins = "gph0-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
+		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+	};
+
+	bt_wake: bt-wake-pins {
+		samsung,pins = "gph1-3";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
+		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+	};
+
 	msense_reset: msense-reset-pins {
 		samsung,pins = "gpg2-0";
 		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
@@ -536,7 +557,25 @@ &sd1_cmd {
 
 /* Bluetooth */
 &serial_0 {
-	status = "disabled";
+	pinctrl-0 = <&uart0_data &uart0_fctl>;
+	pinctrl-names = "default";
+
+	bluetooth {
+		compatible = "brcm,bcm4330-bt";
+
+		pinctrl-0 = <&bt_reg_on &bt_wake &bt_host_wakeup>;
+		pinctrl-names = "default";
+
+		shutdown-gpios = <&gph0 0 GPIO_ACTIVE_HIGH>;
+		device-wakeup-gpios = <&gph1 3 GPIO_ACTIVE_HIGH>;
+
+		interrupt-parent = <&gpx2>;
+		interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-names = "host-wakeup";
+
+		clocks = <&max77686 MAX77686_CLK_PMIC>;
+		clock-names = "lpo";
+	};
 };
 
 /* GPS */

---
base-commit: e5f7e05a699f41275d6380c497293446034bc8af
change-id: 20260404-manta-bluetooth-836133028bb6

Best regards,
--  
Lukas Timmermann <linux@timmermann.space>

Re: [PATCH] ARM: dts: exynos: Add bluetooth support to manta

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 08/04/2026 13:56, Lukas Timmermann wrote:
> Enable the bcm4330-bt device for manta boards on serial0.
> Also adds the necessary pin definitions and interrupt handling for
> wakeup.
> 
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> Co-developed-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>

Incomplete/incorrect DCO chain. Please do not reorder tags. Git does
them correctly, so you HAD to change them manually.

You send the patch or you apply the patch so you must commit with sign off.

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: exynos: Add bluetooth support to manta

Posted by Lukas Timmermann 1 day, 12 hours ago

#include <atomic>
On Mon, Apr 27, 2026 at 03:49:34PM +0200, Krzysztof Kozlowski wrote:
> On 08/04/2026 13:56, Lukas Timmermann wrote:
> > Enable the bcm4330-bt device for manta boards on serial0.
> > Also adds the necessary pin definitions and interrupt handling for
> > wakeup.
> > 
> > Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> > Co-developed-by: Alexandre Marquet <tb@a-marquet.fr>
> > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> 
> Incomplete/incorrect DCO chain. Please do not reorder tags. Git does
> them correctly, so you HAD to change them manually.
> 
> You send the patch or you apply the patch so you must commit with sign off.
I developed the actual patch based on his findings. We both don't really
care about who is mentioned first or anything.

Sorry. Yes I rearranged stuff. So it should be:

co-dev: alex
sign-off: alex
co-dev: me
sign-off: me

Correct?
> 
> Best regards,
> Krzysztof
> 

Best regards,
Lukas

Re: [PATCH] ARM: dts: exynos: Add bluetooth support to manta

Posted by Krzysztof Kozlowski 15 hours ago

On 13/06/2026 19:11, Lukas Timmermann wrote:
> #include <atomic>
> On Mon, Apr 27, 2026 at 03:49:34PM +0200, Krzysztof Kozlowski wrote:
>> On 08/04/2026 13:56, Lukas Timmermann wrote:
>>> Enable the bcm4330-bt device for manta boards on serial0.
>>> Also adds the necessary pin definitions and interrupt handling for
>>> wakeup.
>>>
>>> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
>>> Co-developed-by: Alexandre Marquet <tb@a-marquet.fr>
>>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
>>
>> Incomplete/incorrect DCO chain. Please do not reorder tags. Git does
>> them correctly, so you HAD to change them manually.
>>
>> You send the patch or you apply the patch so you must commit with sign off.
> I developed the actual patch based on his findings. We both don't really
> care about who is mentioned first or anything.
> 
> Sorry. Yes I rearranged stuff. So it should be:
> 
> co-dev: alex
> sign-off: alex
> co-dev: me
> sign-off: me
> 
> Correct?
>>

Yes



Best regards,
Krzysztof