[v1] media: iris: use IRQF_NO_AUTOEN when requesting the IRQ

[PATCH] media: iris: use IRQF_NO_AUTOEN when requesting the IRQ

Posted by Dmitry Baryshkov 2 months, 1 week ago

Requesting the IRQ and then immediately disabling it is fragile as it
leaves a window when the IRQ is still enabled although the underlying
device might be not completely setup for IRQ handling. Pass
IRQF_NO_AUTOEN instead of calling disable_irq_nosync().

Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 drivers/media/platform/qcom/iris/iris_probe.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
index ddaacda523ec..baec43acd6b6 100644
--- a/drivers/media/platform/qcom/iris/iris_probe.c
+++ b/drivers/media/platform/qcom/iris/iris_probe.c
@@ -245,12 +245,12 @@ static int iris_probe(struct platform_device *pdev)
 	core->iris_platform_data = of_device_get_match_data(core->dev);
 
 	ret = devm_request_threaded_irq(core->dev, core->irq, iris_hfi_isr,
-					iris_hfi_isr_handler, IRQF_TRIGGER_HIGH, "iris", core);
+					iris_hfi_isr_handler,
+					IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN,
+					"iris", core);
 	if (ret)
 		return ret;
 
-	disable_irq_nosync(core->irq);
-
 	iris_init_ops(core);
 	core->iris_platform_data->init_hfi_command_ops(core);
 	core->iris_platform_data->init_hfi_response_ops(core);

---
base-commit: 816f193dd0d95246f208590924dd962b192def78
change-id: 20260408-iris-no-autoen-56e8679aef94

Best regards,
--  
With best wishes
Dmitry

Re: [PATCH] media: iris: use IRQF_NO_AUTOEN when requesting the IRQ

Posted by Dikshita Agarwal 1 month, 3 weeks ago


On 4/8/2026 6:43 PM, Dmitry Baryshkov wrote:
> Requesting the IRQ and then immediately disabling it is fragile as it
> leaves a window when the IRQ is still enabled although the underlying
> device might be not completely setup for IRQ handling. Pass
> IRQF_NO_AUTOEN instead of calling disable_irq_nosync().
> 
> Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  drivers/media/platform/qcom/iris/iris_probe.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 


Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>

Thanks,
Dikshita

Re: [PATCH] media: iris: use IRQF_NO_AUTOEN when requesting the IRQ

Posted by Konrad Dybcio 2 months, 1 week ago

On 4/8/26 3:13 PM, Dmitry Baryshkov wrote:
> Requesting the IRQ and then immediately disabling it is fragile as it
> leaves a window when the IRQ is still enabled although the underlying
> device might be not completely setup for IRQ handling. Pass
> IRQF_NO_AUTOEN instead of calling disable_irq_nosync().
> 
> Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---

I assume this was found the hard way..

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad