[PATCH v4 0/5] platform/x86: hp-wmi: Victus S fan control fixes

Emre Cecanpunar posted 5 patches 2 months ago
drivers/platform/x86/hp/hp-wmi.c | 54 ++++++++++++++++++++++----------
1 file changed, 37 insertions(+), 17 deletions(-)
[PATCH v4 0/5] platform/x86: hp-wmi: Victus S fan control fixes
Posted by Emre Cecanpunar 2 months ago
Bug fixes for the Victus S manual fan control:
- Propagate fan_count_userdefine_trigger() errors
- Fix cancel_delayed_work_sync() deadlock from work handler
- Use mod_delayed_work() for efficient keep-alive timer resets
- Fix u8 underflow in gpu_delta calculation
- Add mutex for concurrent hwmon state access

Changes in v4:
- Patch 4: Prevent line wrap in gpu_delta assignment.
- Patch 5: Use devm_mutex_init() and handle init errors.

Changes in v3:
- Add Fixes: tags to all patches.
- Patch 4: Remove unnecessary casting.

Changes in v2:
- Patch 4: Store gpu_delta as 'int' to handle negative deltas correctly.

Emre Cecanpunar (5):
  platform/x86: hp-wmi: fix ignored return values in fan settings
  platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler
  platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer
  platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation
  platform/x86: hp-wmi: add locking for concurrent hwmon access

 drivers/platform/x86/hp/hp-wmi.c | 54 ++++++++++++++++++++++----------
 1 file changed, 37 insertions(+), 17 deletions(-)

-- 
2.53.0
Re: [PATCH v4 0/5] platform/x86: hp-wmi: Victus S fan control fixes
Posted by Ilpo Järvinen 2 months ago
On Tue, 07 Apr 2026 17:25:09 +0300, Emre Cecanpunar wrote:

> Bug fixes for the Victus S manual fan control:
> - Propagate fan_count_userdefine_trigger() errors
> - Fix cancel_delayed_work_sync() deadlock from work handler
> - Use mod_delayed_work() for efficient keep-alive timer resets
> - Fix u8 underflow in gpu_delta calculation
> - Add mutex for concurrent hwmon state access
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/5] platform/x86: hp-wmi: fix ignored return values in fan settings
      commit: 7265b57fbc32782d02bdb8d865ba0d8efa209c8c
[2/5] platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler
      commit: 249ddba9c0ba4453c0a6bc0e3626e7864751d940
[3/5] platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer
      commit: 6297443beb0c5606399ec7d4f4b335e2e7379147
[4/5] platform/x86: hp-wmi: fix u8 underflow in gpu_delta calculation
      commit: cb4daa450f05447c1f914eaef75b2577c25a0fcd
[5/5] platform/x86: hp-wmi: add locking for concurrent hwmon access
      commit: 5969c55e2145368254194edbe0e64880314be69f

--
 i.