ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m

[PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m

Posted by Jian Zhang 2 months, 2 weeks ago

Building with CONFIG_KUNIT=m and CONFIG_SSIF_IPMI_BMC_KUNIT_TEST=y
results in link errors such as:

  undefined reference to `kunit_binary_assert_format'
  undefined reference to `__kunit_do_failed_assertion'

This happens because the test code is built-in while the KUnit core
is built as a module, so the required KUnit symbols are not available
at link time.

Fix this by requiring KUNIT to be built-in when enabling
SSIF_IPMI_BMC_KUNIT_TEST.

Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202604071448.zUBjPYPu-lkp@intel.com/
---
 drivers/char/ipmi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index 72559f6050eb..669f76000197 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -189,7 +189,7 @@ config SSIF_IPMI_BMC
 
 config SSIF_IPMI_BMC_KUNIT_TEST
 	bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS
-	depends on KUNIT
+	depends on KUNIT=y
 	depends on SSIF_IPMI_BMC
 	default KUNIT_ALL_TESTS
 	help
-- 
2.20.1

Re: [PATCH] ipmi: ssif_bmc: Fix KUnit test link failure when KUNIT=m

Posted by Corey Minyard 2 months, 2 weeks ago

On Tue, Apr 07, 2026 at 05:46:47PM +0800, Jian Zhang wrote:
> Building with CONFIG_KUNIT=m and CONFIG_SSIF_IPMI_BMC_KUNIT_TEST=y
> results in link errors such as:
> 
>   undefined reference to `kunit_binary_assert_format'
>   undefined reference to `__kunit_do_failed_assertion'
> 
> This happens because the test code is built-in while the KUnit core
> is built as a module, so the required KUnit symbols are not available
> at link time.
> 
> Fix this by requiring KUNIT to be built-in when enabling
> SSIF_IPMI_BMC_KUNIT_TEST.

Got it, thanks.

-corey

> 
> Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604071448.zUBjPYPu-lkp@intel.com/
> ---
>  drivers/char/ipmi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
> index 72559f6050eb..669f76000197 100644
> --- a/drivers/char/ipmi/Kconfig
> +++ b/drivers/char/ipmi/Kconfig
> @@ -189,7 +189,7 @@ config SSIF_IPMI_BMC
>  
>  config SSIF_IPMI_BMC_KUNIT_TEST
>  	bool "KUnit tests for SSIF IPMI BMC driver" if !KUNIT_ALL_TESTS
> -	depends on KUNIT
> +	depends on KUNIT=y
>  	depends on SSIF_IPMI_BMC
>  	default KUNIT_ALL_TESTS
>  	help
> -- 
> 2.20.1