.../bindings/thermal/thermal-idle.yaml | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-)
Thermal bindings expect the node name with all the zones to be named
'thermal-zones' (hyphen instead of underscore) and thermal zones to end
with '-thermal'. Also DTS coding style is not to use underscores for
node names. After using correct names, bindings point warnings for
missing properties, so add also thermal-sensors. Drop fake top
compatible as it is not useful in this context.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v2:
1. Drop top level compatible and other properties
2. Add thermal-sensors
3. Rename also trips and cpu-thermal
---
.../bindings/thermal/thermal-idle.yaml | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/thermal-idle.yaml b/Documentation/devicetree/bindings/thermal/thermal-idle.yaml
index 1b77d542a7b8..bd420545803f 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-idle.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-idle.yaml
@@ -51,11 +51,6 @@ examples:
/{
#include <dt-bindings/thermal/thermal.h>
- compatible = "foo";
- model = "foo";
- #address-cells = <1>;
- #size-cells = <1>;
-
// Example: Combining idle cooling device on big CPUs with cpufreq cooling device
cpus {
#address-cells = <2>;
@@ -101,33 +96,34 @@ examples:
/* ... */
- thermal_zones {
- cpu_thermal: cpu {
+ thermal-zones {
+ cpu_thermal: cpu-thermal {
polling-delay-passive = <100>;
polling-delay = <1000>;
+ thermal-sensors = <&tsens0 1>;
/* ... */
trips {
- cpu_alert0: cpu_alert0 {
+ cpu_alert0: cpu-alert0 {
temperature = <65000>;
hysteresis = <2000>;
type = "passive";
};
- cpu_alert1: cpu_alert1 {
+ cpu_alert1: cpu-alert1 {
temperature = <70000>;
hysteresis = <2000>;
type = "passive";
};
- cpu_alert2: cpu_alert2 {
+ cpu_alert2: cpu-alert2 {
temperature = <75000>;
hysteresis = <2000>;
type = "passive";
};
- cpu_crit: cpu_crit {
+ cpu_crit: cpu-crit {
temperature = <95000>;
hysteresis = <2000>;
type = "critical";
--
2.51.0On Tue, 07 Apr 2026 07:39:58 +0200, Krzysztof Kozlowski wrote: > Thermal bindings expect the node name with all the zones to be named > 'thermal-zones' (hyphen instead of underscore) and thermal zones to end > with '-thermal'. Also DTS coding style is not to use underscores for > node names. After using correct names, bindings point warnings for > missing properties, so add also thermal-sensors. Drop fake top > compatible as it is not useful in this context. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > --- > > Changes in v2: > 1. Drop top level compatible and other properties > 2. Add thermal-sensors > 3. Rename also trips and cpu-thermal > --- > .../bindings/thermal/thermal-idle.yaml | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: 'compatible' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: 'model' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/root-node.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260407053957.10508-2-krzysztof.kozlowski@oss.qualcomm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 4/7/26 21:29, Rob Herring (Arm) wrote: > > On Tue, 07 Apr 2026 07:39:58 +0200, Krzysztof Kozlowski wrote: >> Thermal bindings expect the node name with all the zones to be named >> 'thermal-zones' (hyphen instead of underscore) and thermal zones to end >> with '-thermal'. Also DTS coding style is not to use underscores for >> node names. After using correct names, bindings point warnings for >> missing properties, so add also thermal-sensors. Drop fake top >> compatible as it is not useful in this context. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> >> >> --- >> >> Changes in v2: >> 1. Drop top level compatible and other properties >> 2. Add thermal-sensors >> 3. Rename also trips and cpu-thermal >> --- >> .../bindings/thermal/thermal-idle.yaml | 18 +++++++----------- >> 1 file changed, 7 insertions(+), 11 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: Hi Krzysztof, what about this error ? > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: 'compatible' is a required property > from schema $id: http://devicetree.org/schemas/root-node.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: 'model' is a required property > from schema $id: http://devicetree.org/schemas/root-node.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: '#address-cells' is a required property > from schema $id: http://devicetree.org/schemas/root-node.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/thermal-idle.example.dtb: /: '#size-cells' is a required property > from schema $id: http://devicetree.org/schemas/root-node.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.kernel.org/project/devicetree/patch/20260407053957.10508-2-krzysztof.kozlowski@oss.qualcomm.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On 20/04/2026 20:06, Daniel Lezcano wrote: > On 4/7/26 21:29, Rob Herring (Arm) wrote: >> >> On Tue, 07 Apr 2026 07:39:58 +0200, Krzysztof Kozlowski wrote: >>> Thermal bindings expect the node name with all the zones to be named >>> 'thermal-zones' (hyphen instead of underscore) and thermal zones to end >>> with '-thermal'. Also DTS coding style is not to use underscores for >>> node names. After using correct names, bindings point warnings for >>> missing properties, so add also thermal-sensors. Drop fake top >>> compatible as it is not useful in this context. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> >>> >>> --- >>> >>> Changes in v2: >>> 1. Drop top level compatible and other properties >>> 2. Add thermal-sensors >>> 3. Rename also trips and cpu-thermal >>> --- >>> .../bindings/thermal/thermal-idle.yaml | 18 +++++++----------- >>> 1 file changed, 7 insertions(+), 11 deletions(-) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: > > Hi Krzysztof, > > what about this error ? It's real and it answers why fake model and compatible properties were there in the first place. Please drop the patch from your queue, I will prepare v3 at some point but needs a bit more time. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.