[PATCH] crypto: af_alg - use sock_kmemdup in alg_setkey_by_key_serial

Thorsten Blum posted 1 patch 2 months, 1 week ago
crypto/af_alg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] crypto: af_alg - use sock_kmemdup in alg_setkey_by_key_serial
Posted by Thorsten Blum 2 months, 1 week ago
Replace sock_kmalloc() followed by memcpy() with sock_kmemdup() to
simplify alg_setkey_by_key_serial().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 crypto/af_alg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index 8e0199394984..25d2bfae31dc 100644
--- a/crypto/af_alg.c
+++ b/crypto/af_alg.c
@@ -324,15 +324,13 @@ static int alg_setkey_by_key_serial(struct alg_sock *ask, sockptr_t optval,
 		return PTR_ERR(ret);
 	}
 
-	key_data = sock_kmalloc(&ask->sk, key_datalen, GFP_KERNEL);
+	key_data = sock_kmemdup(&ask->sk, ret, key_datalen, GFP_KERNEL);
 	if (!key_data) {
 		up_read(&key->sem);
 		key_put(key);
 		return -ENOMEM;
 	}
 
-	memcpy(key_data, ret, key_datalen);
-
 	up_read(&key->sem);
 	key_put(key);
Re: [PATCH] crypto: af_alg - use sock_kmemdup in alg_setkey_by_key_serial
Posted by Herbert Xu 2 months ago
On Sun, Apr 05, 2026 at 09:49:41PM +0200, Thorsten Blum wrote:
> Replace sock_kmalloc() followed by memcpy() with sock_kmemdup() to
> simplify alg_setkey_by_key_serial().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  crypto/af_alg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt