[PATCH v4 0/2] media: atomisp: clean up ISP configuration path

Jose A. Perez de Azpillaga posted 2 patches 2 months, 1 week ago
drivers/staging/media/atomisp/pci/sh_css_sp.c | 41 +++++++++----------
1 file changed, 19 insertions(+), 22 deletions(-)
[PATCH v4 0/2] media: atomisp: clean up ISP configuration path
Posted by Jose A. Perez de Azpillaga 2 months, 1 week ago
NOT TESTED, REVIEW CAREFULLY.

This series cleans up technical debt in the ISP configuration path of
the AtomISP driver.

Resolves a long-standing FIXME by gating ref and TNR frame configuration
behind the ISP feature flags that already govern their allocation,
rather than unconditionally attempting to use frames that may not have
been built into the pipeline, and removes a duplicate call that
overwrites the same cached state with identical values.

v4:
- Added more information on why it is safe to remove the duplicate
  call.
- Added link to v3.

v3:
- Picked up RB tag from Andy Shevchenko.
- Fixed typo. (either -> neither)
- Removed 'staging:' from subject lines.
- Added links to previous versions.

v2:
- Replaced NULL checks with feature flag guards to address the root
  cause rather than the symptom.
- Updated subject line and commit message accordingly in patch 1/2.
- Expanded commit message to explain why the duplicate call is safe to
  remove in patch 2/2.
- Updated subject line in patch 2/2.

Link [v3]: https://lore.kernel.org/linux-staging/20260402183402.444630-1-azpijr@gmail.com/
Link [v2]: https://lore.kernel.org/linux-staging/20260331211649.421777-1-azpijr@gmail.com/
Link [v1]: https://lore.kernel.org/linux-staging/20260328192721.255493-1-azpijr@gmail.com/

Jose A. Perez de Azpillaga (2):
  media: atomisp: gate ref and tnr frame config behind ISP enable flags
  media: atomisp: remove redundant call to ia_css_output0_configure()

 drivers/staging/media/atomisp/pci/sh_css_sp.c | 41 +++++++++----------
 1 file changed, 19 insertions(+), 22 deletions(-)

--
2.53.0
Re: [PATCH v4 0/2] media: atomisp: clean up ISP configuration path
Posted by Jose A. Perez de Azpillaga 1 month ago
On Sun, Apr 05, 2026 at 11:30:42AM +0200, Jose A. Perez de Azpillaga wrote:
> NOT TESTED, REVIEW CAREFULLY.
>
> This series cleans up technical debt in the ISP configuration path of
> the AtomISP driver.
>
> Resolves a long-standing FIXME by gating ref and TNR frame configuration
> behind the ISP feature flags that already govern their allocation,
> rather than unconditionally attempting to use frames that may not have
> been built into the pipeline, and removes a duplicate call that
> overwrites the same cached state with identical values.

hi,

just a gentle ping for this series. please let me know if there's
anything that I should do.

regards,

--
jose a. p-a