perf test: Skip sched stats test for !root

[PATCH] perf test: Skip sched stats test for !root

Posted by Namhyung Kim 2 months, 1 week ago

Running perf sched stats requires root and it fails to open the
schedstat file for regular users.  Let's skip the test.

  $ perf sched stats true
  Failed to open /proc/sys/kernel/sched_schedstats

Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/perf/tests/shell/perf_sched_stats.sh b/tools/perf/tests/shell/perf_sched_stats.sh
index 2b1410b050d04737..41ee41fbf0253d55 100755
--- a/tools/perf/tests/shell/perf_sched_stats.sh
+++ b/tools/perf/tests/shell/perf_sched_stats.sh
@@ -4,6 +4,11 @@
 
 set -e
 
+if [ "$(id -u)" != 0 ]; then
+  echo "[Skip] No root permission"
+  exit 2
+fi
+
 err=0
 test_perf_sched_stats_record() {
   echo "Basic perf sched stats record test"
-- 
2.53.0

Re: [PATCH] perf test: Skip sched stats test for !root

Posted by Namhyung Kim 2 months, 1 week ago

On Sat, Apr 04, 2026 at 10:16:44PM -0700, Namhyung Kim wrote:
> Running perf sched stats requires root and it fails to open the
> schedstat file for regular users.  Let's skip the test.
> 
>   $ perf sched stats true
>   Failed to open /proc/sys/kernel/sched_schedstats
> 
> Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] perf test: Skip sched stats test for !root

Posted by Swapnil Sapkal 2 months, 1 week ago

Hi Namhyung,

On 05-04-2026 10:46, Namhyung Kim wrote:
> Running perf sched stats requires root and it fails to open the
> schedstat file for regular users.  Let's skip the test.
> 
>    $ perf sched stats true
>    Failed to open /proc/sys/kernel/sched_schedstats
> 
> Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Tested-by: Swapnil Sapkal <swapnil.sapkal@amd.com>

--
Thanks and Regards,
Swapnil

> ---
>   tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/perf_sched_stats.sh b/tools/perf/tests/shell/perf_sched_stats.sh
> index 2b1410b050d04737..41ee41fbf0253d55 100755
> --- a/tools/perf/tests/shell/perf_sched_stats.sh
> +++ b/tools/perf/tests/shell/perf_sched_stats.sh
> @@ -4,6 +4,11 @@
>   
>   set -e
>   
> +if [ "$(id -u)" != 0 ]; then
> +  echo "[Skip] No root permission"
> +  exit 2
> +fi
> +
>   err=0
>   test_perf_sched_stats_record() {
>     echo "Basic perf sched stats record test"

Re: [PATCH] perf test: Skip sched stats test for !root

Posted by Ian Rogers 2 months, 1 week ago

On Sat, Apr 4, 2026 at 10:16 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> Running perf sched stats requires root and it fails to open the
> schedstat file for regular users.  Let's skip the test.
>
>   $ perf sched stats true
>   Failed to open /proc/sys/kernel/sched_schedstats
>
> Cc: Swapnil Sapkal <swapnil.sapkal@amd.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/perf_sched_stats.sh | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/tests/shell/perf_sched_stats.sh b/tools/perf/tests/shell/perf_sched_stats.sh
> index 2b1410b050d04737..41ee41fbf0253d55 100755
> --- a/tools/perf/tests/shell/perf_sched_stats.sh
> +++ b/tools/perf/tests/shell/perf_sched_stats.sh
> @@ -4,6 +4,11 @@
>
>  set -e
>
> +if [ "$(id -u)" != 0 ]; then
> +  echo "[Skip] No root permission"
> +  exit 2
> +fi
> +
>  err=0
>  test_perf_sched_stats_record() {
>    echo "Basic perf sched stats record test"
> --
> 2.53.0
>