staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c

[PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c

Posted by Hungyu Lin 2 months, 1 week ago

Remove redundant return statements at the end of void functions
in rtw_mlme_ext.c.

No functional change.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index dad1d95bc325..335f5b2c96f0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
 
 
 	dump_mgntframe(padapter, pmgntframe);
-
-	return;
-
 }
 
 static int _issue_probereq(struct adapter *padapter,
@@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
 			issue_action_BSSCoexistPacket(padapter);
 		}
 	}
-
-	return;
-
 }
 
 /* collect bss info from Beacon and Probe request/response frames. */
@@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
 
 	pmlmeext->sitesurvey_res.bss_cnt++;
-
-	return;
-
 }
 
 void report_surveydone_event(struct adapter *padapter)
@@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
 	psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_join_res(struct adapter *padapter, int res)
@@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
 	pwmm_event->wmm = 0;
 
 	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
-
-	return;
-
 }
 
 void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: remove redundant returns in rtw_mlme_ext.c

Posted by Luka Gejak 2 months, 1 week ago

On Sat Apr 4, 2026 at 1:48 PM CEST, Hungyu Lin wrote:
> Remove redundant return statements at the end of void functions
> in rtw_mlme_ext.c.
>
> No functional change.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index dad1d95bc325..335f5b2c96f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -2417,9 +2417,6 @@ void issue_probersp(struct adapter *padapter, unsigned char *da, u8 is_valid_p2p
>  
>  
>  	dump_mgntframe(padapter, pmgntframe);
> -
> -	return;
> -
>  }
>  
>  static int _issue_probereq(struct adapter *padapter,
> @@ -3877,9 +3874,6 @@ void site_survey(struct adapter *padapter)
>  			issue_action_BSSCoexistPacket(padapter);
>  		}
>  	}
> -
> -	return;
> -
>  }
>  
>  /* collect bss info from Beacon and Probe request/response frames. */
> @@ -4414,9 +4408,6 @@ void report_survey_event(struct adapter *padapter, union recv_frame *precv_frame
>  	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
>  
>  	pmlmeext->sitesurvey_res.bss_cnt++;
> -
> -	return;
> -
>  }
>  
>  void report_surveydone_event(struct adapter *padapter)
> @@ -4458,9 +4449,6 @@ void report_surveydone_event(struct adapter *padapter)
>  	psurveydone_evt->bss_cnt = pmlmeext->sitesurvey_res.bss_cnt;
>  
>  	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> -	return;
> -
>  }
>  
>  void report_join_res(struct adapter *padapter, int res)
> @@ -4549,9 +4537,6 @@ void report_wmm_edca_update(struct adapter *padapter)
>  	pwmm_event->wmm = 0;
>  
>  	rtw_enqueue_cmd(pcmdpriv, pcmd_obj);
> -
> -	return;
> -
>  }
>  
>  void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsigned short reason)
LGTM
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak